From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DATE_IN_PAST_12_24, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84F98C43331 for ; Mon, 30 Mar 2020 06:27:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 58A042082F for ; Mon, 30 Mar 2020 06:27:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585549648; bh=YhYNb7spyVxkfCJi4xuEQir7TVe0wbthheTdqNXZCww=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=NOkW+r/OtAr5v+3pCDtJXg3Ma+2BV8gekh9b2L794Oo9wvBd58v5SlKktC33DfXa1 RC074QgDk1CBKIqRor2I5MdzFOtqwk9zlbJM7SyyWbpEUz+X43ch7bfjSywq9X0HLj XNinQJhjx3wYYTY4AvFYQUo4e1P1jzwjqnRSkQ80= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728997AbgC3G11 (ORCPT ); Mon, 30 Mar 2020 02:27:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:44238 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728489AbgC3G11 (ORCPT ); Mon, 30 Mar 2020 02:27:27 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E7DF520732; Mon, 30 Mar 2020 06:27:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585549646; bh=YhYNb7spyVxkfCJi4xuEQir7TVe0wbthheTdqNXZCww=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CmT3PifYvNRYJDblnKoVVj33ecVxmOMFk23+/Z9tEnlyp7YPSZdJl5T0SJorRd6/j fawma9PHBXphCpDsiTZr0lXifSH96dPuX5t8dtZtdJWm/xJuDkZy/ZjcAw2Q5++kM2 sQY6jYXnflbRHkIkV2MCUVkhEixxWeMqdBUc2yuY= Date: Sun, 29 Mar 2020 11:00:07 +0300 From: Leon Romanovsky To: Jason Gunthorpe Cc: Doug Ledford , Mark Zhang , linux-rdma@vger.kernel.org, Maor Gottlieb Subject: Re: [PATCH rdma-next v1 6/7] RDMA/cm: Set flow label of recv_wc based on primary flow label Message-ID: <20200329080007.GC2454444@unreal> References: <20200322093031.918447-1-leon@kernel.org> <20200322093031.918447-7-leon@kernel.org> <20200327123733.GA6821@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200327123733.GA6821@ziepe.ca> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Fri, Mar 27, 2020 at 09:37:33AM -0300, Jason Gunthorpe wrote: > On Sun, Mar 22, 2020 at 11:30:30AM +0200, Leon Romanovsky wrote: > > From: Mark Zhang > > > > In the request handler of the response side, Set flow label of the > > recv_wc if it is not net. It will be used for all messages sent > > by the responder. > > > > Signed-off-by: Mark Zhang > > Reviewed-by: Maor Gottlieb > > Signed-off-by: Leon Romanovsky > > drivers/infiniband/core/cm.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c > > index bbbfa77dbce7..4ab2f71da522 100644 > > +++ b/drivers/infiniband/core/cm.c > > @@ -2039,6 +2039,7 @@ static int cm_req_handler(struct cm_work *work) > > struct cm_req_msg *req_msg; > > const struct ib_global_route *grh; > > const struct ib_gid_attr *gid_attr; > > + struct ib_grh *ibgrh; > > int ret; > > > > req_msg = (struct cm_req_msg *)work->mad_recv_wc->recv_buf.mad; > > @@ -2048,6 +2049,12 @@ static int cm_req_handler(struct cm_work *work) > > if (IS_ERR(cm_id_priv)) > > return PTR_ERR(cm_id_priv); > > > > + ibgrh = work->mad_recv_wc->recv_buf.grh; > > + if (!(be32_to_cpu(ibgrh->version_tclass_flow) & IB_GRH_FLOWLABEL_MASK)) > > + ibgrh->version_tclass_flow |= > > + cpu_to_be32(IBA_GET(CM_REQ_PRIMARY_FLOW_LABEL, > > + req_msg)); > > This doesn't seem right. I will check, this part looks strange while reading IBTA sections "13.5.4.3 CONSTRUCTING A RESPONSE WITHOUT A GRH" and "13.5.4.4 CONSTRUCTING A RESPONSE WITH A GRH" Thanks