linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: George Spelvin <lkml@sdf.org>
Cc: linux-kernel@vger.kernel.org,
	Dennis Dalessandro <dennis.dalessandro@intel.com>,
	Mike Marciniszyn <mike.marciniszyn@intel.com>,
	linux-rdma@vger.kernel.org
Subject: Re: [RFC PATCH v1 01/50] IB/qib: Delete struct qib_ivdev.qp_rnd
Date: Sun, 29 Mar 2020 11:17:10 -0300	[thread overview]
Message-ID: <20200329141710.GE20941@ziepe.ca> (raw)
In-Reply-To: <202003281643.02SGh6eG002694@sdf.org>

On Wed, Mar 27, 2019 at 12:55:00PM -0400, George Spelvin wrote:
> I was checking the field to see if it needed the full
> get_random_bytes() and discovered it's unused.
> 
> Only compile-tested, as I don't have the hardware, but
> I'm still pretty confident.
> 
> Signed-off-by: George Spelvin <lkml@sdf.org>
> Cc: Dennis Dalessandro <dennis.dalessandro@intel.com>
> Cc: Mike Marciniszyn <mike.marciniszyn@intel.com>
> Cc: linux-rdma@vger.kernel.org
> ---
>  drivers/infiniband/hw/qib/qib_verbs.c | 2 --
>  drivers/infiniband/hw/qib/qib_verbs.h | 1 -
>  2 files changed, 3 deletions(-)

You need to do a better job sending your patches, this is not
threaded, and not cc'd to linux-rdma, so it doesn't show in the
patchworks.

In general, do not send such large series for things that are not
connected. Send small cleanups like this properly and directly so they
can be applied.

I took care of it this time, so applied to the rdma tree as it is
obviously correct.

Thanks,
Jason

  reply	other threads:[~2020-03-29 14:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-27 16:55 [RFC PATCH v1 01/50] IB/qib: Delete struct qib_ivdev.qp_rnd George Spelvin
2020-03-29 14:17 ` Jason Gunthorpe [this message]
2020-03-29 16:08   ` George Spelvin
2020-03-30 13:28     ` Mark Rutland
2020-03-30 16:43       ` George Spelvin
2020-03-30 16:49         ` Jason Gunthorpe
2020-04-01 12:26           ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200329141710.GE20941@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=dennis.dalessandro@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=lkml@sdf.org \
    --cc=mike.marciniszyn@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).