From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66920C2BA1B for ; Mon, 6 Apr 2020 17:35:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 341142137B for ; Mon, 6 Apr 2020 17:35:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586194548; bh=tq3v2w0mhXlmrDdStTyBk1PZSD5fE8jBsSw0NOGUYjs=; h=From:To:Cc:Subject:Date:List-ID:From; b=gfl8B0cM6szAyIbe2x2HIwoge2QpeCv/w+Ax0M/of20MfAZz1cREUoXi9y6/q66bm JxVHDyDJYqU9jdFEAVPGFvYhJik3uG/fDgI0JmQE8gVV+1D1QMTJZjjnQQyE5cS63W tYE8b6zW8/hdGAknsJCFw6t0bSejTale7I8TQlzA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728117AbgDFRfr (ORCPT ); Mon, 6 Apr 2020 13:35:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:38374 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726492AbgDFRfr (ORCPT ); Mon, 6 Apr 2020 13:35:47 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 67FD2206C0; Mon, 6 Apr 2020 17:35:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586194547; bh=tq3v2w0mhXlmrDdStTyBk1PZSD5fE8jBsSw0NOGUYjs=; h=From:To:Cc:Subject:Date:From; b=UdJuTG/ksp62+VR7FeLk6mZLloqcCFbXphGku9+0bd8o4Cffli0FQlxuT+Jonv0NE W6icidHPYru72fgol8ndxhhA8aRWeczvFUlJlX0z9tzmFnDzfqFviSDAo/Q6s/GpQf 04KWZiUODFWlbmZACbHBZ6J6wtrPwzNxLT6Hj+Lo= From: Leon Romanovsky To: Doug Ledford , Jason Gunthorpe Cc: Yishai Hadas , Eli Cohen , Jack Morgenstein , linux-rdma@vger.kernel.org, Or Gerlitz , Roland Dreier Subject: [PATCH rdma-rc] RDMA/mlx5: Fix udata response upon SRQ creation Date: Mon, 6 Apr 2020 20:35:40 +0300 Message-Id: <20200406173540.1466477-1-leon@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Yishai Hadas Fix udata response upon SRQ creation to use the UAPI structure (i.e. mlx5_ib_create_srq_resp). Fixes: e126ba97dba9 ("mlx5: Add driver for Mellanox Connect-IB adapters") Signed-off-by: Yishai Hadas Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/srq.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/srq.c b/drivers/infiniband/hw/mlx5/srq.c index b1a8a9175040..3c2a84c362bb 100644 --- a/drivers/infiniband/hw/mlx5/srq.c +++ b/drivers/infiniband/hw/mlx5/srq.c @@ -310,12 +310,17 @@ int mlx5_ib_create_srq(struct ib_srq *ib_srq, srq->msrq.event = mlx5_ib_srq_event; srq->ibsrq.ext.xrc.srq_num = srq->msrq.srqn; - if (udata) - if (ib_copy_to_udata(udata, &srq->msrq.srqn, sizeof(__u32))) { + if (udata) { + struct mlx5_ib_create_srq_resp resp = {}; + + resp.srqn = srq->msrq.srqn; + if (ib_copy_to_udata(udata, &resp, min(udata->outlen, + sizeof(resp)))) { mlx5_ib_dbg(dev, "copy to user failed\n"); err = -EFAULT; goto err_core; } + } init_attr->attr.max_wr = srq->msrq.max - 1; -- 2.25.1