linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: bfields@fieldses.org (J. Bruce Fields)
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Chuck Lever <chuck.lever@oracle.com>,
	Leon Romanovsky <leon@kernel.org>,
	Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
	linux-rdma@vger.kernel.org
Subject: Re: [PATCH v1 3/3] svcrdma: Fix leak of svc_rdma_recv_ctxt objects
Date: Mon, 13 Apr 2020 15:29:07 -0400	[thread overview]
Message-ID: <20200413192907.GA23596@fieldses.org> (raw)
In-Reply-To: <20200409174750.GK11886@ziepe.ca>

On Thu, Apr 09, 2020 at 02:47:50PM -0300, Jason Gunthorpe wrote:
> On Thu, Apr 09, 2020 at 10:33:32AM -0400, Chuck Lever wrote:
> > The commit ID is what automation should key off of. The short
> > description is only for human consumption. 
> 
> Right, so if the actual commit message isn't included so humans can
> read it then what was the point of including anything?

Personally as a human reading commits in a terminal window I prefer the
abbreviated form.

I haven't been doing the redundant parentheses and quotes either.  Was
that dreamt up by an Arlo Guthrie fan?  ("KID, HAVE YOU REHABILITATED
YOURSELF?")

--b.

  parent reply	other threads:[~2020-04-13 19:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07 19:10 [PATCH v1 0/3] NFS/RDMA server fixes for 5.7-rc Chuck Lever
2020-04-07 19:10 ` [PATCH v1 1/3] svcrdma: Fix trace point use-after-free race Chuck Lever
2020-04-07 19:11 ` [PATCH v1 2/3] SUNRPC: Remove naked ->xpo_release_rqst from svc_send() Chuck Lever
2020-04-07 19:11 ` [PATCH v1 3/3] svcrdma: Fix leak of svc_rdma_recv_ctxt objects Chuck Lever
2020-04-08  6:02   ` Leon Romanovsky
2020-04-09 14:33     ` Chuck Lever
2020-04-09 17:47       ` Jason Gunthorpe
2020-04-09 17:59         ` Chuck Lever
2020-04-13 19:29         ` J. Bruce Fields [this message]
2020-04-14 12:19           ` Jason Gunthorpe
2020-04-14 15:13             ` J. Bruce Fields
2020-04-14 15:20               ` Jason Gunthorpe
2020-04-14 16:17                 ` J. Bruce Fields
2020-04-14 18:11                   ` Leon Romanovsky
2020-04-14 18:15                     ` Jason Gunthorpe
2020-04-16 19:05                   ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200413192907.GA23596@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=chuck.lever@oracle.com \
    --cc=jgg@ziepe.ca \
    --cc=leon@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).