From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2336C2BB1D for ; Wed, 15 Apr 2020 00:41:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3FEF20774 for ; Wed, 15 Apr 2020 00:41:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="YGLvHs8p" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407876AbgDOAl5 (ORCPT ); Tue, 14 Apr 2020 20:41:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1733064AbgDOAlz (ORCPT ); Tue, 14 Apr 2020 20:41:55 -0400 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2029C061A0C for ; Tue, 14 Apr 2020 17:41:55 -0700 (PDT) Received: by mail-qk1-x743.google.com with SMTP id x66so15508075qkd.9 for ; Tue, 14 Apr 2020 17:41:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=eo385VfZcGAz7coUgjGWNzMa0vEHywn06GjdqDem0NY=; b=YGLvHs8pYWq8xOGZpyM0F/OH7orZNDtMeXefo+v908z8GZXUl9dNS4lKl7OFo8zXT6 56UQaKdOOLmPU1+bEqyUUwXvt2I8QZmkBxTxjCiADlGQiexX1PhXEXmznGHWpAcBYBzn eJTbupadIfCG6uO1W4gwhw+cFI4E+GkhKuy1hX2YPzWiE1yT5LvCmAxmEDB/c6fMRe5c X7qhcNqHtrvMqGrszYAVba23f3CmjLK1bXbK59NJWUiVl9xKOn+5pPXCjh+z43zwSzCh egHZEDvxawIXzZ8kF5KJ3PudFm1XdnyG9vh2rEHV2QduEO2moRoMRoyUlo0qj5xt6baZ +LEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=eo385VfZcGAz7coUgjGWNzMa0vEHywn06GjdqDem0NY=; b=UKnf8376UvU6nL9Dtlp2GhrhQvoAnEr5S/hMJSYIPWl1ZEbDdBFKG9ogjccbxH1LIU vBwY6keYCQvf+nWHgCBIqp6wI7cWbasOexiieIoP90HziZ142jRXtMK/nSPzJHRo7C8c zlTvlfOc3dFkb0Rm9TaWgNETOmXsVl90Cfgct6OWGNkGK7586ZqY7fcYejnEhvRcBbqU OZX9hhsg51wCCAqC19Fr+1Jwdz5YigXlbXy6xGruNPL5yrikSUvWLRNY3CPq+fIVBZty fQpS6bN79lrSczaXbb70myKlm+wAx8Zmugjjp0GLiKI5B2kqiWShwdPQeKxQZ5uVQS4f TrEQ== X-Gm-Message-State: AGi0PuaHfQmaMVuJyJCC9XhIHRCwaKb/+FAitT0f6ZxOa0+bfHD4vE47 ttONkMQeCQb8Q/xVSecaGQEPAw== X-Google-Smtp-Source: APiQypLglDzqCDqMLVb5A1TB1kZOz4RvLejsXTssywOz6b9TW05QtDw6BdZK2lmpxbPssI8Holb0uA== X-Received: by 2002:a05:620a:1259:: with SMTP id a25mr12781217qkl.323.1586911314698; Tue, 14 Apr 2020 17:41:54 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id p22sm2068507qte.2.2020.04.14.17.41.54 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Apr 2020 17:41:54 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jOW7l-0006br-Lu; Tue, 14 Apr 2020 21:41:53 -0300 Date: Tue, 14 Apr 2020 21:41:53 -0300 From: Jason Gunthorpe To: Leon Romanovsky Cc: Doug Ledford , Alaa Hleihel , linux-rdma@vger.kernel.org, Maor Gottlieb , Or Gerlitz , Roland Dreier , Yishai Hadas Subject: Re: [PATCH rdma-rc] RDMA/mlx4: Initialize ib_spec on the stack Message-ID: <20200415004153.GA25366@ziepe.ca> References: <20200413132235.930642-1-leon@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200413132235.930642-1-leon@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Apr 13, 2020 at 04:22:35PM +0300, Leon Romanovsky wrote: > From: Alaa Hleihel > > Initialize ib_spec on the stack before using it, otherwise we will > have garbage values that will break creating default rules with > invalid parsing error. > > Fixes: a37a1a428431 ("IB/mlx4: Add mechanism to support flow steering over IB links") > Signed-off-by: Alaa Hleihel > Reviewed-by: Maor Gottlieb > Signed-off-by: Leon Romanovsky > --- > drivers/infiniband/hw/mlx4/main.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied to for-rc, thanks Jason