From: Leon Romanovsky <leon@kernel.org>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Jianxin Xiong <jianxin.xiong@intel.com>,
linux-rdma@vger.kernel.org, Doug Ledford <dledford@redhat.com>,
Sumit Semwal <sumit.semwal@linaro.org>
Subject: Re: [RFC PATCH 1/3] RDMA/umem: Support importing dma-buf as user memory region
Date: Thu, 16 Apr 2020 21:30:33 +0300 [thread overview]
Message-ID: <20200416183033.GI1309273@unreal> (raw)
In-Reply-To: <20200416180407.GV5100@ziepe.ca>
On Thu, Apr 16, 2020 at 03:04:07PM -0300, Jason Gunthorpe wrote:
> On Thu, Apr 16, 2020 at 09:02:01PM +0300, Leon Romanovsky wrote:
>
> > > diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
> > > index ade8638..1dcfc59 100644
> > > +++ b/drivers/infiniband/Kconfig
> > > @@ -63,6 +63,16 @@ config INFINIBAND_ON_DEMAND_PAGING
> > > memory regions without pinning their pages, fetching the
> > > pages on demand instead.
> > >
> > > +config INFINIBAND_DMABUF
> >
> > There is no need to add extra config, it is not different from any
> > other verbs feature which is handled by some sort of mask.
>
> That works too, but then it infiniband_user_mem needs the
> depends on DMABUF || !DMABUF construct
IS_REACHABLE() ? :)
>
> > > + if (access & IB_ACCESS_ON_DEMAND)
> > > + return ERR_PTR(-EOPNOTSUPP);
> >
> > Does dma-buf really need to prohibit ODP?
>
> ODP fundamentally can only be applied to a mm_struct
Right, I forgot about it, thanks.
>
> Jason
next prev parent reply other threads:[~2020-04-16 18:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 17:09 [RFC PATCH 0/3] RDMA: Add dma-buf support Jianxin Xiong
2020-04-16 17:09 ` [RFC PATCH 1/3] RDMA/umem: Support importing dma-buf as user memory region Jianxin Xiong
2020-04-16 18:01 ` Jason Gunthorpe
2020-04-16 19:41 ` Xiong, Jianxin
2020-04-17 12:31 ` Jason Gunthorpe
2020-04-17 15:49 ` Xiong, Jianxin
2020-04-16 18:02 ` Leon Romanovsky
2020-04-16 18:04 ` Jason Gunthorpe
2020-04-16 18:30 ` Leon Romanovsky [this message]
2020-04-16 21:08 ` Xiong, Jianxin
2020-04-16 17:09 ` [RFC PATCH 2/3] RDMA/uverbs: Add uverbs commands for fd-based MR registration Jianxin Xiong
2020-04-16 17:47 ` Jason Gunthorpe
2020-04-16 18:32 ` Xiong, Jianxin
2020-04-17 12:35 ` Jason Gunthorpe
2020-04-16 17:09 ` [RFC PATCH 3/3] RDMA/mlx5: Support new uverbs commands for registering fd-based MR Jianxin Xiong
2020-04-16 17:54 ` [RFC PATCH 0/3] RDMA: Add dma-buf support Jason Gunthorpe
2020-04-16 19:08 ` Xiong, Jianxin
2020-04-16 19:34 ` Jason Gunthorpe
2020-04-16 21:02 ` Xiong, Jianxin
2020-04-17 12:35 ` Jason Gunthorpe
2020-04-17 16:49 ` Xiong, Jianxin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416183033.GI1309273@unreal \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=jianxin.xiong@intel.com \
--cc=linux-rdma@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).