From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FC48C54FC9 for ; Tue, 21 Apr 2020 12:10:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5EA50206A5 for ; Tue, 21 Apr 2020 12:10:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726628AbgDUMKA (ORCPT ); Tue, 21 Apr 2020 08:10:00 -0400 Received: from verein.lst.de ([213.95.11.211]:46318 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726018AbgDUMKA (ORCPT ); Tue, 21 Apr 2020 08:10:00 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 6E6EE68C4E; Tue, 21 Apr 2020 14:09:57 +0200 (CEST) Date: Tue, 21 Apr 2020 14:09:57 +0200 From: Christoph Hellwig To: Max Gurtovoy Cc: linux-nvme@lists.infradead.org, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me, martin.petersen@oracle.com, jsmart2021@gmail.com, linux-rdma@vger.kernel.org, idanb@mellanox.com, axboe@kernel.dk, vladimirk@mellanox.com, oren@mellanox.com, shlomin@mellanox.com, israelr@mellanox.com, jgg@mellanox.com Subject: Re: [PATCH 04/17] nvme: introduce max_integrity_segments ctrl attribute Message-ID: <20200421120957.GE26432@lst.de> References: <20200327171545.98970-1-maxg@mellanox.com> <20200327171545.98970-6-maxg@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200327171545.98970-6-maxg@mellanox.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Fri, Mar 27, 2020 at 08:15:32PM +0300, Max Gurtovoy wrote: > + /* > + * NVMe PCI driver doesn't support Extended LBA format and supports > + * only a single integrity segment for a separate contiguous buffer > + * of metadata. > + */ That isn't strictly true, PCIe can also support SGLs for metadata. I'd rather ѕay something like: /* * We do not support an SGL for metadata (yet), so we are limited * to a single integrity segment for the separate metadata pointer. */ Except for that this looks good: Reviewed-by: Christoph Hellwig