From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6E5CC7C860 for ; Mon, 27 Apr 2020 15:47:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B5327206B6 for ; Mon, 27 Apr 2020 15:47:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588002478; bh=GPTW75LjRKlWLOqhmRFai8HVJqHeGEdTIc2AB7OGqF4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=slUnr2riidzta09O8IBTpAUtZ5htM14gtvi+j6N4k/UzR6VEOZ2Z0AQ1DG1trxz6O N6kh7Q361wvHdP50dZD0jymyiS1K3w4xCkTZMe9t43v0wssn1kRQlNTt/nn64G0Vx3 aI68xpbm4l+gTMF+KixJB9qyqUZtcxKR098px59s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728320AbgD0Pr5 (ORCPT ); Mon, 27 Apr 2020 11:47:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:55072 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728313AbgD0Pr5 (ORCPT ); Mon, 27 Apr 2020 11:47:57 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 49E76206D9; Mon, 27 Apr 2020 15:47:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588002477; bh=GPTW75LjRKlWLOqhmRFai8HVJqHeGEdTIc2AB7OGqF4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y6pQBKrWyGLn8NvPZ9EDYgladRnztzGNisiLhLmlTez2fGsmZApviYL+d/M20xf9O UJD9Y/Y+PgrYMJANvIkOSwYIDn0ybl9D/v3uW7T9pUBS/yK74+oBqODtJjyiE5pJjO uAZTpCYulSUcF+jLTcfGREBVFJltdkWRztUXvTQI= From: Leon Romanovsky To: Doug Ledford , Jason Gunthorpe Cc: Leon Romanovsky , RDMA mailing list , Aharon Landau , Eli Cohen , Maor Gottlieb Subject: [PATCH rdma-next v1 21/36] RDMA/mlx5: Promote RSS RAW QP attribute check in higher level Date: Mon, 27 Apr 2020 18:46:21 +0300 Message-Id: <20200427154636.381474-22-leon@kernel.org> X-Mailer: git-send-email 2.25.3 In-Reply-To: <20200427154636.381474-1-leon@kernel.org> References: <20200427154636.381474-1-leon@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Leon Romanovsky Perform check of attributes of RAW PACKET QP in separate function. Reviewed-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/qp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c index 0d3f4bafe448..454433a18b97 100644 --- a/drivers/infiniband/hw/mlx5/qp.c +++ b/drivers/infiniband/hw/mlx5/qp.c @@ -1645,9 +1645,6 @@ static int create_rss_raw_qp_tir(struct ib_pd *pd, struct mlx5_ib_qp *qp, size_t required_cmd_sz; u8 lb_flag = 0; - if (init_attr->send_cq) - return -EINVAL; - min_resp_len = offsetof(typeof(resp), bfreg_index) + sizeof(resp.bfreg_index); if (udata->outlen < min_resp_len) return -EINVAL; @@ -2693,6 +2690,9 @@ static int check_qp_attr(struct mlx5_ib_dev *dev, struct mlx5_ib_qp *qp, -EINVAL : 0; break; + case IB_QPT_RAW_PACKET: + ret = (attr->rwq_ind_tbl && attr->send_cq) ? -EINVAL : 0; + break; default: break; } -- 2.25.3