From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C7F8C7C860 for ; Mon, 27 Apr 2020 15:48:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B50220728 for ; Mon, 27 Apr 2020 15:48:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588002494; bh=xENY5ur1nU/tNXzq4DYvLG+ws8fSZcBIMJuWaw+CMmg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ncSpsYSiWhUR2uedOzQBJF172Pzvc8h4EIw31rgfujNGpnyjeDY3lixwozO77wCzL cSuQ23m3I0sdsT6mLxboHRPFiY/b1P9lhDVE1gyeuHeOQzA1xixhTJtvzuvjiYA4lC DZ8olyvfJb1bC+c2GNfe8azerT+zIOZHMlwxjr9M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728298AbgD0PsM (ORCPT ); Mon, 27 Apr 2020 11:48:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:55774 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728038AbgD0PsM (ORCPT ); Mon, 27 Apr 2020 11:48:12 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4F78F206D9; Mon, 27 Apr 2020 15:48:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588002492; bh=xENY5ur1nU/tNXzq4DYvLG+ws8fSZcBIMJuWaw+CMmg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JqJfuVc7+LcL1oIF4AVUOkhsptZhlrC77Kz35hnXnViRTCWL7G3frLy+AdUrmDqXR LUZFmjrcF/QZE1+7Zor/Tr62NDw1LwaPWvGeM3GibehaePw2t4n1ixGw8wiXiCkLXL rkO6n/kclk/kHt8x4qIifCNwAwyV/AEgmR9JeV8A= From: Leon Romanovsky To: Doug Ledford , Jason Gunthorpe Cc: Leon Romanovsky , RDMA mailing list , Aharon Landau , Eli Cohen , Maor Gottlieb Subject: [PATCH rdma-next v1 25/36] RDMA/mlx5: Delete impossible inlen check Date: Mon, 27 Apr 2020 18:46:25 +0300 Message-Id: <20200427154636.381474-26-leon@kernel.org> X-Mailer: git-send-email 2.25.3 In-Reply-To: <20200427154636.381474-1-leon@kernel.org> References: <20200427154636.381474-1-leon@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Leon Romanovsky The inlen is set to be above zero in all flows before and can't be negative at this stage. Reviewed-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/qp.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c index 74f09cdb4a33..5a43128d651b 100644 --- a/drivers/infiniband/hw/mlx5/qp.c +++ b/drivers/infiniband/hw/mlx5/qp.c @@ -2107,11 +2107,6 @@ static int create_qp_common(struct mlx5_ib_dev *dev, struct ib_pd *pd, qp->flags &= ~IB_QP_CREATE_PCI_WRITE_END_PADDING; } - if (inlen < 0) { - err = -EINVAL; - goto err; - } - if (init_attr->qp_type == IB_QPT_RAW_PACKET || qp->flags & IB_QP_CREATE_SOURCE_QPN) { qp->raw_packet_qp.sq.ubuffer.buf_addr = ucmd->sq_buf_addr; @@ -2156,8 +2151,6 @@ static int create_qp_common(struct mlx5_ib_dev *dev, struct ib_pd *pd, destroy_qp_user(dev, pd, qp, base, udata); else destroy_qp_kernel(dev, qp); - -err: kvfree(in); return err; } -- 2.25.3