From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EDC1C7C862 for ; Mon, 27 Apr 2020 15:48:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E5C0206BF for ; Mon, 27 Apr 2020 15:48:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588002536; bh=HY1XDZRcc1ZE0uomFZfYG27zwhU2MVYOfmctqwNMIHg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=n1OVcdvTLVDapuiabku5XReHvInJKWsPGeNPeSVXMWnumHVXRhWvkKBv1C2YLUt2S DXcjefB9hNX5y11sAhmZuOhc7UEuHRy/AZNbEBCJl2MFcenClL/BC4d+0m4X4oIXT5 zOIjj2oaV05SDUP2krLPsps4ebdfMx/OUTNz9OOI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728430AbgD0Psz (ORCPT ); Mon, 27 Apr 2020 11:48:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:57768 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728425AbgD0Psy (ORCPT ); Mon, 27 Apr 2020 11:48:54 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AFF272064C; Mon, 27 Apr 2020 15:48:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588002534; bh=HY1XDZRcc1ZE0uomFZfYG27zwhU2MVYOfmctqwNMIHg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XuFUzuvz4lQyab2CyulX+kGdDcnsfJdugATvyb5Qwzho/FRkr9Z5DMr5eGa14Elvc aptH5WKmsEup4wSfILl0NHn1QL4mq600AnqS7cOIznPNExVSCP4SgzJMjkfcdrtDfB hXfdUvKgnLLBdUsYmnHz5xNomAuinSBS0Jh3IjuE= From: Leon Romanovsky To: Doug Ledford , Jason Gunthorpe Cc: Aharon Landau , RDMA mailing list , Eli Cohen , Maor Gottlieb Subject: [PATCH rdma-next v1 36/36] RDMA/mlx5: Verify that QP is created with RQ or SQ Date: Mon, 27 Apr 2020 18:46:36 +0300 Message-Id: <20200427154636.381474-37-leon@kernel.org> X-Mailer: git-send-email 2.25.3 In-Reply-To: <20200427154636.381474-1-leon@kernel.org> References: <20200427154636.381474-1-leon@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Aharon Landau RAW packet QP and underlay QP must be created with either RQ or SQ, check that. Fixes: e126ba97dba9 ("mlx5: Add driver for Mellanox Connect-IB adapters") Signed-off-by: Aharon Landau Reviewed-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/qp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c index 18c0a25da47a..14f4f0982e4e 100644 --- a/drivers/infiniband/hw/mlx5/qp.c +++ b/drivers/infiniband/hw/mlx5/qp.c @@ -1482,6 +1482,8 @@ static int create_raw_packet_qp(struct mlx5_ib_dev *dev, struct mlx5_ib_qp *qp, u16 uid = to_mpd(pd)->uid; u32 out[MLX5_ST_SZ_DW(create_tir_out)] = {}; + if (!qp->sq.wqe_cnt && !qp->rq.wqe_cnt) + return -EINVAL; if (qp->sq.wqe_cnt) { err = create_raw_packet_qp_tis(dev, qp, sq, tdn, pd); if (err) -- 2.25.3