From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22885C433DF for ; Tue, 19 May 2020 23:46:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE1DE20674 for ; Tue, 19 May 2020 23:46:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="jXx4VJ+9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726881AbgESXqw (ORCPT ); Tue, 19 May 2020 19:46:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725998AbgESXqv (ORCPT ); Tue, 19 May 2020 19:46:51 -0400 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB6B9C061A0E for ; Tue, 19 May 2020 16:46:51 -0700 (PDT) Received: by mail-qk1-x743.google.com with SMTP id 142so1844276qkl.6 for ; Tue, 19 May 2020 16:46:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=EZ3w/dTFCdeQDnc5fZLNBPSrCy5eNFWI04k57XtzKOU=; b=jXx4VJ+9t3i6gDkDjplc/D+KPwAczZFkHP6J2PT6CIutMBDMZi9gDlVw7L7jsGJPNC eFugtwTwXUdZ1Nvz+vRscTxBrwEn3ClePlgHpav2J3NfQ3iuLhxoYXNT3gf+ZlE90GBU lY+pmWHrM2tEvrCOJZyzqWwNgWG8IRHh4NL/UdhuckIHJj1v9kYZbt6JG0Z9wY2yta+b pWNLna4+3CAYNJJAb735TOlEhe7ayRx7DQqSNOvA8yaGphTQNhNKYRSnOEfp0sQn+/7U oZdORieWAJ95ELNa8mP52Pp5wnsaGECGpmtCBy+mfz2Q0Gj+klrIIJu4HEDmJye41m82 WbMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=EZ3w/dTFCdeQDnc5fZLNBPSrCy5eNFWI04k57XtzKOU=; b=Tjhr0lQ2LtEqExhZgU+OB9UGgTf9c3kHhg8qk4wld5Pet5zVoq9O8ekLXxbkm0v61u J1Oy9Jhq5GvTM1SLVar2Oeoq4y2D+3wEZHy6eNlVxPhpP0ZS6rFkpw/pJkaOqqavIJLj a9cjA8mb6AngfX9AxDmn5ZIjuFKqDKt/rWlpu1rd50cA2uPDGypuA2bhpEHh85A8FLQT bfplmUUsD55Td/iZtIhVlbWo8ySjVvAPEfBtacdwWEoGK9+K3yuhWaOA4FJjWKnHBed5 ReHFLX5UdIDadHXeqDGwqku8JeaTjrjv1oI4BdXgcSu1fHpa4WwB0eGxrxt65K1QYvm2 UJzw== X-Gm-Message-State: AOAM531YCHyZWQzZFNyrysc4oibXQo4Pq1aposX8vWDMTxWlAsuViKgA o4esBX2sOBUsGpdnqS1+XsB9YA== X-Google-Smtp-Source: ABdhPJw4RRZlSUYpdIrXm0xYqrUMah4E94MBUSKzQ9DMxhy7RFs/HWzOylhu7E0nkTztuoec09r7qg== X-Received: by 2002:a37:84a:: with SMTP id 71mr1989448qki.56.1589932011041; Tue, 19 May 2020 16:46:51 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id k13sm1017287qtm.80.2020.05.19.16.46.50 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 May 2020 16:46:50 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jbBwg-00080m-60; Tue, 19 May 2020 20:46:50 -0300 Date: Tue, 19 May 2020 20:46:50 -0300 From: Jason Gunthorpe To: Dan Carpenter Cc: Danil Kipnis , Jack Wang , Doug Ledford , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] RDMA/rtrs: Fix a couple off by one bugs in rtrs_srv_rdma_done() Message-ID: <20200519234650.GD30609@ziepe.ca> References: <20200519154525.GA66801@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200519154525.GA66801@mwanda> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, May 19, 2020 at 06:45:25PM +0300, Dan Carpenter wrote: > These > comparisons should be >= to prevent accessing one element > beyond the end of the buffer. > > Fixes: 9cb837480424 ("RDMA/rtrs: server: main functionality") > Signed-off-by: Dan Carpenter > Acked-by: Danil Kipnis > --- > drivers/infiniband/ulp/rtrs/rtrs-srv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to for-next, thanks Jason