From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69D0FC433E0 for ; Fri, 29 May 2020 18:20:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 463212067B for ; Fri, 29 May 2020 18:20:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="c66p9MDv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726849AbgE2SUj (ORCPT ); Fri, 29 May 2020 14:20:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725839AbgE2SUi (ORCPT ); Fri, 29 May 2020 14:20:38 -0400 Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD85AC08C5C8 for ; Fri, 29 May 2020 11:20:38 -0700 (PDT) Received: by mail-qt1-x842.google.com with SMTP id j32so2692064qte.10 for ; Fri, 29 May 2020 11:20:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ChhpnWyJyVmgjoRJH/BNQYkEfM9pIhC10bAvWTPw9XM=; b=c66p9MDvjQCkyYqa100k4vINobxzfBj3Y8NAHDbCTmPN2OlFwO9UjZ77O+0kLagv1C Md7C4SzY2b7uC2D0Ollg2/GVJ0OjI967BJktCv4ewd205aOc/ZIGMyhTyw19AEcuCO0S hZi9xcL3OGY1kMaCrZl5oWir32Fgyskj7wUy1mmuEMs7rI97GVNLZHIQgSqaWq3ElDRQ ljsVyrwbs5qw3W7z4DB9+VED2DPnrWttEuNcq5aXlIRM7y2rAYlbGWh5qcjNtWVc+eTf uhWW5roqtjd+1dFeF4gEBZk6o7adDpMnH0OIDkbv6TCA1Xt165RTNufO0FULaBbkEQGf 1ldw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ChhpnWyJyVmgjoRJH/BNQYkEfM9pIhC10bAvWTPw9XM=; b=JcNSrKtJRklAmvhVo7Cf2Frb5a6M+HP6Z1buuIzawCjkUrbw241YyZlcnKAzFeOxOJ AHga7foYova4LmBH7YXaW7IKc5Nq49YDqXiEMHOvWVAYYAC9fSKyVfTBopoXf0VTifQZ Lr8tKj7dgYhhbE4XTlKi/EcyR9rTi6R0aCRakMCcOUwKu6Cp9wull6mdJSGRyhzUHTat e+KnNiihBrst+odnk2WjIr2JeQ3F45y56JgmdXvqV3eTsF3HFLrbtSwc8EMjGRllh9W2 zkiYQVwWY0aEevYjd1YIlNp6p4rPSU99JNAxNVOFbAsE5FP6QAGxcMsK1jw78HNOnQ24 1DQg== X-Gm-Message-State: AOAM5316yn2qOL1xF2/xH4i7Y2nbDLwPMborbnIHRQrsWUOaY6lBll7T 0A1pUcxERy2A1Sg4s45b5L7RAw== X-Google-Smtp-Source: ABdhPJwH+mpV+w1wzbF6SpCDz5Hec20m/pxhmwzvv09S/bv5dTD2l+BeoIE6q4qxus4G05ygIRJ+8A== X-Received: by 2002:ac8:bc4:: with SMTP id p4mr10318652qti.72.1590776437985; Fri, 29 May 2020 11:20:37 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id v69sm7734321qkb.96.2020.05.29.11.20.37 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 May 2020 11:20:37 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jejcS-0002xt-Uq; Fri, 29 May 2020 15:20:36 -0300 Date: Fri, 29 May 2020 15:20:36 -0300 From: Jason Gunthorpe To: Colin King Cc: Lijun Ou , Wei Hu , Weihang Li , Doug Ledford , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] RDMA/hns: remove duplicate assignment to pointer raq Message-ID: <20200529182036.GA11361@ziepe.ca> References: <20200528150427.420624-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200528150427.420624-1-colin.king@canonical.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Thu, May 28, 2020 at 04:04:27PM +0100, Colin King wrote: > From: Colin Ian King > > The pointer raq is being assigned twice. Fix this by removing > one of the redundant assignments. > > Fixes: 14ba87304bf9 ("RDMA/hns: Remove redundant type cast for general pointers") > Addressses-Coverity: ("Evaluation order violation") > Signed-off-by: Colin Ian King > --- > drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to for-next Thanks, Jason