From: Dan Carpenter <dan.carpenter@oracle.com>
To: vuhuong@mellanox.com
Cc: linux-rdma@vger.kernel.org
Subject: [bug report] net/mlx5: E-switch, Offloads shift ACL programming during enable/disable vport
Date: Wed, 3 Jun 2020 13:34:33 +0300 [thread overview]
Message-ID: <20200603103433.GD1845750@mwanda> (raw)
Hello Vu Pham,
The patch 748da30b376e: "net/mlx5: E-switch, Offloads shift ACL
programming during enable/disable vport" from Oct 28, 2019, leads to
the following static checker warning:
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c:1979 esw_create_uplink_offloads_acl_tables()
error: 'vport' dereferencing possible ERR_PTR()
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
1970 static int esw_create_uplink_offloads_acl_tables(struct mlx5_eswitch *esw)
1971 {
1972 struct mlx5_vport *vport;
1973 int err;
1974
1975 if (esw_use_vport_metadata(esw))
1976 esw->flags |= MLX5_ESWITCH_VPORT_MATCH_METADATA;
1977
1978 vport = mlx5_eswitch_get_vport(esw, MLX5_VPORT_UPLINK);
No error checking.
1979 err = esw_vport_create_offloads_acl_tables(esw, vport);
1980 if (err)
1981 esw->flags &= ~MLX5_ESWITCH_VPORT_MATCH_METADATA;
1982 return err;
1983 }
regards,
dan carpenter
reply other threads:[~2020-06-03 10:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200603103433.GD1845750@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-rdma@vger.kernel.org \
--cc=vuhuong@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox