From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57F91C433E0 for ; Sun, 5 Jul 2020 13:20:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 328A020747 for ; Sun, 5 Jul 2020 13:20:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593955234; bh=AquMBgAphvp3hTfk08dtsDLX7MT6n+hVBIvbeQNjSq0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=PwcqdgLSF75CQtlfPxUOKqgKRqY/sHnimSUbQLu/fAWfqOYsOhCQSCM3mBxGrCktP lX7YNQ/obmbQKFJxOloAe9vR4DQeQ8ISIBlRw/TY04VwGd33WCrpze2xzox0e9Ckns QBn7kY6gdVF0zEqGaXfIuTXzE+v81u71JvPE47hU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726907AbgGENUd (ORCPT ); Sun, 5 Jul 2020 09:20:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:52662 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726898AbgGENUd (ORCPT ); Sun, 5 Jul 2020 09:20:33 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7712F2073E; Sun, 5 Jul 2020 13:20:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593955233; bh=AquMBgAphvp3hTfk08dtsDLX7MT6n+hVBIvbeQNjSq0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vIZXgWNwe/tok6zFoZO6Z+Ry6d9lOBTSU6QKC/AdsU534WWU2or72m3asypID6mfK wr1+SZAi/mTvA9vh1qImYZQX1z0/8a9SD2QSWwrNNEd5ZRFX75RsMlpHyP6Xt1xeHW SvH1pFaQ+INFE0UWO2R7L2jrAxfe3+J4qUxtn/fI= Date: Sun, 5 Jul 2020 16:20:29 +0300 From: Leon Romanovsky To: Kamal Heib Cc: linux-rdma@vger.kernel.org, Doug Ledford , Jason Gunthorpe , Zhu Yanjun Subject: Re: [PATCH for-next v1 2/4] RDMA/rxe: Return void from rxe_init_port_param() Message-ID: <20200705132029.GE5149@unreal> References: <20200705104313.283034-1-kamalheib1@gmail.com> <20200705104313.283034-3-kamalheib1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200705104313.283034-3-kamalheib1@gmail.com> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Sun, Jul 05, 2020 at 01:43:11PM +0300, Kamal Heib wrote: > The return value from rxe_init_port_param() is always 0 - change it to > be void. > > Fixes: 8700e3e7c485 ("Soft RoCE driver") > Signed-off-by: Kamal Heib > --- > drivers/infiniband/sw/rxe/rxe.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky