From: Kamal Heib <kamalheib1@gmail.com>
To: Gal Pressman <galpress@amazon.com>
Cc: linux-rdma@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>,
Doug Ledford <dledford@redhat.com>
Subject: Re: [PATCH for-next 2/5] RDMA/efa: Set max_pkeys attribute
Date: Mon, 6 Jul 2020 11:16:09 +0300 [thread overview]
Message-ID: <20200706081609.GA363413@kheib-workstation> (raw)
In-Reply-To: <864f9e35-5223-db52-1c6e-ac1b2a4079ed@amazon.com>
On Mon, Jul 06, 2020 at 10:58:34AM +0300, Gal Pressman wrote:
> On 06/07/2020 10:54, Kamal Heib wrote:
> > Make sure to set the max_pkeys attribute to indicate the maximum number
> > of partitions supported by the efa device.
> >
> > Fixes: 40909f664d27 ("RDMA/efa: Add EFA verbs implementation")
> > Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> > Cc: Gal Pressman <galpress@amazon.com>
> > ---
> > drivers/infiniband/hw/efa/efa_verbs.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/infiniband/hw/efa/efa_verbs.c b/drivers/infiniband/hw/efa/efa_verbs.c
> > index 08313f7c73bc..7dd082441333 100644
> > --- a/drivers/infiniband/hw/efa/efa_verbs.c
> > +++ b/drivers/infiniband/hw/efa/efa_verbs.c
> > @@ -212,6 +212,7 @@ int efa_query_device(struct ib_device *ibdev,
> > props->max_send_sge = dev_attr->max_sq_sge;
> > props->max_recv_sge = dev_attr->max_rq_sge;
> > props->max_sge_rd = dev_attr->max_wr_rdma_sge;
> > + props->max_pkeys = 1;
> >
> > if (udata && udata->outlen) {
> > resp.max_sq_sge = dev_attr->max_sq_sge;
> >
>
> Thanks Kamal, a similar patch was already merged:
> f25022a53ef3 ("RDMA/efa: Set maximum pkeys device attribute")
Correct, Now I see it with diff commit id under the for-rc branch,
while I did my work on top of the for-next branch.
I'll send a v2 that drops this patch.
0133654d8eb8 RDMA/efa: Set maximum pkeys device attribute
Thanks,
Kamal
next prev parent reply other threads:[~2020-07-06 8:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 7:54 [PATCH for-next 0/5] RDMA/providers: Set max_pkey attribute Kamal Heib
2020-07-06 7:54 ` [PATCH for-next 1/5] RDMA/siw: Set max_pkeys attribute Kamal Heib
2020-07-06 7:54 ` [PATCH for-next 2/5] RDMA/efa: " Kamal Heib
2020-07-06 7:58 ` Gal Pressman
2020-07-06 8:16 ` Kamal Heib [this message]
2020-07-06 7:54 ` [PATCH for-next 3/5] RDMA/cxgb4: " Kamal Heib
2020-07-06 7:54 ` [PATCH for-next 4/5] RDMA/i40iw: " Kamal Heib
2020-07-06 7:54 ` [PATCH for-next 5/5] RDMA/usnic: Fix reported " Kamal Heib
2020-07-06 9:06 ` [PATCH for-next 0/5] RDMA/providers: Set max_pkey attribute Kamal Heib
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200706081609.GA363413@kheib-workstation \
--to=kamalheib1@gmail.com \
--cc=dledford@redhat.com \
--cc=galpress@amazon.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox