From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F28AC433E0 for ; Mon, 6 Jul 2020 12:32:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B47120715 for ; Mon, 6 Jul 2020 12:32:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594038775; bh=EkDjqWhfNHfJFC/yKEFFyliPxvW+I3KXcTvKIPQHDXQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=SkVjaugmhewRPchYgt62wq7JHUZNW5FKx1eRvvh2Yu3znmHXl5miRF51KgcuKgLHo l2d37nkrvY8GRbemsrtI1vhzpD3kdpnmyYaVsosNhSa2xShZk9E/C7uxMBOsQaWsu7 kiXw/qvuHZGAddUiwCsM38C3PrqGnW5oAKCnx6f8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728885AbgGFMcy (ORCPT ); Mon, 6 Jul 2020 08:32:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:57602 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728414AbgGFMcy (ORCPT ); Mon, 6 Jul 2020 08:32:54 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 91E83206E6; Mon, 6 Jul 2020 12:32:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594038774; bh=EkDjqWhfNHfJFC/yKEFFyliPxvW+I3KXcTvKIPQHDXQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xTJ8UY4NPalXp2/eW5XV7UY84kqm+hja8Rx+6DD4QJyZhv3pI8o9uJ+23RbzUnLsD mI2Al23G8j5vN+9i1GU9S3GZHPJM7kNecIDW+4Udb9BnH8xMZt1I/+QsmsKHEQBrAW oX19EnD0m5PJSZUtS32hHTvJaIv6kJ3pyL99BaME= Date: Mon, 6 Jul 2020 15:32:50 +0300 From: Leon Romanovsky To: Gal Pressman Cc: Jason Gunthorpe , Doug Ledford , linux-rdma@vger.kernel.org, Selvin Xavier , Devesh Sharma , Somnath Kotur , Sriharsha Basavapatna , Potnuri Bharat Teja , Lijun Ou , Weihang Li , Faisal Latif , Shiraz Saleem , Yishai Hadas , Michal Kalderon , Ariel Elior , Adit Ranadive , VMware PV-Drivers , Dennis Dalessandro , Mike Marciniszyn , Zhu Yanjun , Bernard Metzler Subject: Re: [PATCH for-next 1/3] RDMA/core: Check for error instead of success in alloc MR function Message-ID: <20200706123250.GF207186@unreal> References: <20200706120343.10816-1-galpress@amazon.com> <20200706120343.10816-2-galpress@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200706120343.10816-2-galpress@amazon.com> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Jul 06, 2020 at 03:03:41PM +0300, Gal Pressman wrote: > The common kernel pattern is to check for error, not success. > Flip the if statement accordingly and keep the main flow unindented. > > Signed-off-by: Gal Pressman > --- > drivers/infiniband/core/verbs.c | 25 +++++++++++++------------ > 1 file changed, 13 insertions(+), 12 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky