From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Alexander A. Klimov" <grandmaster@al2klimov.de>
Cc: Bart Van Assche <bvanassche@acm.org>,
dledford@redhat.com, linux-rdma@vger.kernel.org,
target-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
Jonathan Corbet <corbet@lwn.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
David Miller <davem@davemloft.net>,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] SCSI RDMA PROTOCOL (SRP) TARGET: Replace HTTP links with HTTPS ones
Date: Mon, 13 Jul 2020 10:50:31 -0300 [thread overview]
Message-ID: <20200713135031.GA25301@ziepe.ca> (raw)
In-Reply-To: <c6b97005-e4c7-0a46-37eb-b5bb187ee919@al2klimov.de>
On Sun, Jul 12, 2020 at 10:15:29PM +0200, Alexander A. Klimov wrote:
>
>
> Am 12.07.20 um 21:52 schrieb Bart Van Assche:
> > On 2020-07-10 11:12, Alexander A. Klimov wrote:
> > > Am 10.07.20 um 16:22 schrieb Bart Van Assche:
> > > > On 2020-07-09 12:48, Alexander A. Klimov wrote:
> > > > > diff --git a/drivers/infiniband/ulp/srpt/Kconfig b/drivers/infiniband/ulp/srpt/Kconfig
> > > > > index 4b5d9b792cfa..f63b34d9ae32 100644
> > > > > +++ b/drivers/infiniband/ulp/srpt/Kconfig
> > > > > @@ -10,4 +10,4 @@ config INFINIBAND_SRPT
> > > > > that supports the RDMA protocol. Currently the RDMA protocol is
> > > > > supported by InfiniBand and by iWarp network hardware. More
> > > > > information about the SRP protocol can be found on the website
> > > > > - of the INCITS T10 technical committee (http://www.t10.org/).
> > > > > + of the INCITS T10 technical committee (https://www.t10.org/).
> > > >
> > > > It is not clear to me how modifying an URL in a Kconfig file helps to
> > > > reduce the attack surface on kernel devs?
> > >
> > > Not on all, just on the ones who open it.
> >
> > Is changing every single HTTP URL in the kernel into a HTTPS URL the best
> > solution? Is this the only solution? Has it been considered to recommend
> > kernel developers who are concerned about MITM attacks to install a browser
> > extension like HTTPS Everywhere instead?
> I've installed that addon myself.
> But IMAO it's just a workaround which is (not available to all browsers, not
> installed by default in any of them and) not even 100% secure unless you
> tick a particular checkbox.
>
> Anyway the majority of maintainers and Torvalds himself agree with my
> solution.
>
> I mean, just look at
> git log '--author=Alexander A. Klimov <grandmaster@al2klimov.de>' \
>
> Or (better) wait for v5.9-rc1 (and all the yet just applied patches it will
> consist of) *and then* run the command.
Well, if you are going to do this please send just one patch for all
of drivers/infiniband/ and include/rdma
I don't need to see it broken up any more than that
Jason
next prev parent reply other threads:[~2020-07-13 13:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 19:48 [PATCH] SCSI RDMA PROTOCOL (SRP) TARGET: Replace HTTP links with HTTPS ones Alexander A. Klimov
2020-07-10 14:22 ` Bart Van Assche
2020-07-10 18:12 ` Alexander A. Klimov
2020-07-12 19:52 ` Bart Van Assche
2020-07-12 20:15 ` Alexander A. Klimov
2020-07-13 13:50 ` Jason Gunthorpe [this message]
2020-07-13 21:48 ` [PATCH v2] IB: " Alexander A. Klimov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713135031.GA25301@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=bvanassche@acm.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=grandmaster@al2klimov.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox