From: Jason Gunthorpe <jgg@nvidia.com>
To: Kamal Heib <kamalheib1@gmail.com>
Cc: <linux-rdma@vger.kernel.org>, Zhu Yanjun <yanjunz@mellanox.com>,
Doug Ledford <dledford@redhat.com>
Subject: Re: [PATCH for-next] RDMA/rxe: Remove pkey table
Date: Fri, 31 Jul 2020 16:22:16 -0300 [thread overview]
Message-ID: <20200731192216.GA525516@nvidia.com> (raw)
In-Reply-To: <20200721101618.686110-1-kamalheib1@gmail.com>
On Tue, Jul 21, 2020 at 01:16:18PM +0300, Kamal Heib wrote:
> The RoCE spec require from RoCE devices to support only the defualt pkey,
> While the rxe driver maintain a 64 enties pkey table and use only the
> first entry. With that said remove the maintaing of the pkey table and
> used the default pkey when needed.
>
> Fixes: 8700e3e7c485 ("Soft RoCE driver")
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> ---
> drivers/infiniband/sw/rxe/rxe.c | 34 +++------------------------
> drivers/infiniband/sw/rxe/rxe_param.h | 4 ++--
> drivers/infiniband/sw/rxe/rxe_recv.c | 29 ++++-------------------
> drivers/infiniband/sw/rxe/rxe_req.c | 5 +---
> drivers/infiniband/sw/rxe/rxe_verbs.c | 17 +++-----------
> drivers/infiniband/sw/rxe/rxe_verbs.h | 1 -
> 6 files changed, 13 insertions(+), 77 deletions(-)
It looks OK to me, but this is not a 'fixes' so I dropped it.
There is no reason a rxe device should have anything other than a
single entry pkey table with the default value
Applied to for-next
Thanks,
Jason
prev parent reply other threads:[~2020-07-31 19:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 10:16 [PATCH for-next] RDMA/rxe: Remove pkey table Kamal Heib
[not found] ` <AM6PR05MB6263CFB337190B1740CDF4B7D8780@AM6PR05MB6263.eurprd05.prod.outlook.com>
2020-07-22 2:09 ` FW: " Zhu Yanjun
2020-07-23 5:57 ` Kamal Heib
2020-07-23 6:58 ` Zhu Yanjun
2020-07-23 7:25 ` Kamal Heib
2020-07-23 13:08 ` Zhu Yanjun
2020-07-23 13:15 ` Jason Gunthorpe
2020-07-23 15:15 ` Zhu Yanjun
2020-07-28 8:35 ` Kamal Heib
2020-07-28 13:21 ` Zhu Yanjun
2020-07-28 13:44 ` Kamal Heib
2020-07-28 15:46 ` Zhu Yanjun
2020-07-28 17:42 ` Kamal Heib
2020-07-28 23:45 ` Zhu Yanjun
2020-07-29 1:36 ` Mark Bloch
2020-07-31 19:22 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731192216.GA525516@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=kamalheib1@gmail.com \
--cc=linux-rdma@vger.kernel.org \
--cc=yanjunz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox