public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leonro@mellanox.com>
To: Max Gurtovoy <maxg@mellanox.com>
Cc: sagi@grimberg.me, linux-rdma@vger.kernel.org, jgg@nvidia.com,
	jgg@mellanox.com, dledford@redhat.com, oren@mellanox.com
Subject: Re: [PATCH 1/2] IB/isert: use unlikely macro in the fast path
Date: Wed, 5 Aug 2020 16:16:44 +0300	[thread overview]
Message-ID: <20200805131644.GJ4432@unreal> (raw)
In-Reply-To: <20200805121231.166162-1-maxg@mellanox.com>

On Wed, Aug 05, 2020 at 03:12:30PM +0300, Max Gurtovoy wrote:
> Add performance optimization that might slightly improve small IO sizes
> benchmarks.
>
> Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
> ---
>  drivers/infiniband/ulp/isert/ib_isert.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I find the expectation from "unlikely/likely" keywords to be overrated.

When we introduced dissagregate post send verbs in rdma-core, we
benchmarked likely/unlikely and didn't find any significant difference
for code with and without such keywords.

Thanks

  parent reply	other threads:[~2020-08-05 19:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-05 12:12 [PATCH 1/2] IB/isert: use unlikely macro in the fast path Max Gurtovoy
2020-08-05 12:12 ` [PATCH 2/2] IB/isert: remove duplicated error prints Max Gurtovoy
2020-08-06 20:12   ` Sagi Grimberg
2020-08-18 18:41   ` Jason Gunthorpe
2020-08-05 13:16 ` Leon Romanovsky [this message]
2020-08-05 15:14   ` [PATCH 1/2] IB/isert: use unlikely macro in the fast path Max Gurtovoy
2020-08-05 16:06     ` Leon Romanovsky
2020-08-05 16:28       ` Max Gurtovoy
2020-08-05 16:37         ` Leon Romanovsky
2020-08-06 10:56           ` Max Gurtovoy
2020-08-06 19:51           ` Sagi Grimberg
2020-08-07 16:09             ` Leon Romanovsky
2020-08-07 16:33               ` Sagi Grimberg
2020-08-06 19:43 ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200805131644.GJ4432@unreal \
    --to=leonro@mellanox.com \
    --cc=dledford@redhat.com \
    --cc=jgg@mellanox.com \
    --cc=jgg@nvidia.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=maxg@mellanox.com \
    --cc=oren@mellanox.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox