From: jackm <jackm@dev.mellanox.co.il>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>, Mark Bloch <markb@mellanox.com>,
Eli Cohen <eli@mellanox.co.il>,
linux-rdma@vger.kernel.org, Maor Gottlieb <maorg@nvidia.com>,
Roland Dreier <rolandd@cisco.com>,
Yishai Hadas <yishaih@nvidia.com>
Subject: Re: [PATCH rdma-rc] RDMA/mlx4: Read pkey table length instead of hardcoded value
Date: Sun, 23 Aug 2020 17:06:06 +0300 [thread overview]
Message-ID: <20200823170606.00004757@dev.mellanox.co.il> (raw)
In-Reply-To: <20200823123342.GC571722@unreal>
On Sun, 23 Aug 2020 15:33:42 +0300
Leon Romanovsky <leon@kernel.org> wrote:
> "props" are cleared by definition of IB/core to make sure that drivers
> doesn't return junk in ->query_port() for the fields that are not
> assigned. This is why I removed redundant assignment to 0.
>
> Thanks
OK, got it. I remove my objection. No RoCE support basically means that
the pkey_tbl_len field should be treated as an unassigned field (which
will remain zero, like all the other unassigned fields).
-Jack
prev parent reply other threads:[~2020-08-23 14:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-23 6:17 [PATCH rdma-rc] RDMA/mlx4: Read pkey table length instead of hardcoded value Leon Romanovsky
2020-08-23 11:27 ` jackm
2020-08-23 12:33 ` Leon Romanovsky
2020-08-23 14:06 ` jackm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200823170606.00004757@dev.mellanox.co.il \
--to=jackm@dev.mellanox.co.il \
--cc=dledford@redhat.com \
--cc=eli@mellanox.co.il \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=maorg@nvidia.com \
--cc=markb@mellanox.com \
--cc=rolandd@cisco.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox