Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH v3 0/3] IB CM tracepoints
Date: Mon, 24 Aug 2020 18:56:11 -0300	[thread overview]
Message-ID: <20200824215611.GM1152540@nvidia.com> (raw)
In-Reply-To: <5C1EC1AC-8385-4E08-9C4A-97B04AF3763B@oracle.com>

On Mon, Aug 24, 2020 at 02:24:40PM -0400, Chuck Lever wrote:
> 
> 
> > On Aug 24, 2020, at 1:42 PM, Jason Gunthorpe <jgg@nvidia.com> wrote:
> > 
> > On Mon, Aug 17, 2020 at 09:53:05AM -0400, Chuck Lever wrote:
> >> Oracle has an interest in a common observability infrastructure in
> >> the RDMA core and ULPs. Introduce static tracepoints that can also
> >> be used as hooks for eBPF scripts, replacing infrastructure that
> >> is based on printk. This takes the same approach as tracepoints
> >> added recently in the RDMA CM.
> >> 
> >> Change since v2:
> >> * Rebase on v5.9-rc1
> >> 
> >> Changes since RFC:
> >> * Correct spelling of example tracepoint in patch description
> >> * Newer tool chains don't care for tracepoints with the same name
> >> in different subsystems
> >> * Display ib_cm_events, not ib_events
> > 
> > Doesn't compile:
> > 
> > In file included from drivers/infiniband/core/cm_trace.h:414,
> >                 from drivers/infiniband/core/cm_trace.c:15:
> > ./include/trace/define_trace.h:95:42: fatal error: ./cm_trace.h: No such file or directory
> >   95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
> >      |                                          ^
> > compilation terminated.
> 
> I am not able to reproduce this failure.
> 
> gcc (GCC) 10.1.1 20200507 (Red Hat 10.1.1-1)

Yep, using gcc 10 too

Start from a clean tree?
 
> What if you edit drivers/infiniband/core/cm_trace.h and
> change the definition of TRACE_INCLUDE_PATH from "." to
> "../../drivers/infiniband/core" ?

It works

It is because ./ is relative to include/trace/define_trace.h ?
 
Jason

  reply	other threads:[~2020-08-24 21:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-17 13:53 [PATCH v3 0/3] IB CM tracepoints Chuck Lever
2020-08-17 13:53 ` [PATCH v3 1/3] RDMA/core: Move the rdma_show_ib_cm_event() macro Chuck Lever
2020-08-17 13:53 ` [PATCH v3 2/3] RDMA/cm: Replace pr_debug() call sites with tracepoints Chuck Lever
2020-08-17 13:53 ` [PATCH v3 3/3] RDMA/cm: Add tracepoints to track MAD send operations Chuck Lever
2020-08-24 17:42 ` [PATCH v3 0/3] IB CM tracepoints Jason Gunthorpe
2020-08-24 17:43   ` Chuck Lever
2020-08-24 18:24   ` Chuck Lever
2020-08-24 21:56     ` Jason Gunthorpe [this message]
2020-08-24 22:30       ` Chuck Lever
2020-08-24 22:40         ` Jason Gunthorpe
2020-08-25 17:05 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200824215611.GM1152540@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=chuck.lever@oracle.com \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox