Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Bob Pearson <rpearsonhpe@gmail.com>
To: leon@kernel.org, zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org
Cc: Bob Pearson <rpearson@hpe.com>
Subject: [PATCH] Fix tests/test_device.py
Date: Mon, 24 Aug 2020 20:23:44 -0500	[thread overview]
Message-ID: <20200825012344.5696-1-rpearson@hpe.com> (raw)

Removed a test case which requires vendor_part_id to be non zero.
Per IBTA A3.3.1 VENDOR INFORMATION it is not required that the
vendor part ID field be set to a non-zero value:

	The following components are vendor specific: VendorID, DeviceID, De-
	vice Version, Subsystem VendorID, SubsystemID, ID String.

	The vendor places its IEEE assigned Organization Unique Identifier
	(OUI) in the VendorId field and *MAY PLACE ANY VALUE IN THE DEVICEID* and
	Device Version fields. The vendor may also provide an ASCII string of its
	choice in the ID String field.

	The Subsystem VendorID and SubsystemID provide additional informa-
	tion when a subsystem vendor uses components provided by other ven-
	dors. In this case the subsystem vendor provides its OUI in the Subsystem
	VendorID field and may specify any value in the SubsystemD field.
	A vendor that produces a generic controller (i.e., one that supports a stan-
	dard I/O protocol such as SRP), which does not have vendor specific de-
	vice drivers, may use the value of 0xFFFFFF in the VendorID field.
	However, such a value prevents the vendor from ever providing vendor
	specific drivers for the product.

Signed-off-by: Bob Pearson <rpearson@hpe.com>
---
 tests/test_device.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/test_device.py b/tests/test_device.py
index c23caae1..d552f402 100644
--- a/tests/test_device.py
+++ b/tests/test_device.py
@@ -86,7 +86,6 @@ class DeviceTest(PyverbsAPITestCase):
         assert attr.max_mr_size > PAGE_SIZE
         assert attr.page_size_cap >= PAGE_SIZE
         assert attr.vendor_id != 0
-        assert attr.vendor_part_id != 0
         assert attr.max_qp > 0
         assert attr.max_qp_wr > 0
         assert attr.max_sge > 0
-- 
2.25.1


             reply	other threads:[~2020-08-25  1:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25  1:23 Bob Pearson [this message]
2020-08-25  5:09 ` [PATCH] Fix tests/test_device.py Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200825012344.5696-1-rpearson@hpe.com \
    --to=rpearsonhpe@gmail.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=rpearson@hpe.com \
    --cc=zyjzyj2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox