From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11835C433DF for ; Tue, 25 Aug 2020 09:27:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E3DB82068F for ; Tue, 25 Aug 2020 09:27:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g37SMro+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729372AbgHYJ1U (ORCPT ); Tue, 25 Aug 2020 05:27:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726149AbgHYJ1S (ORCPT ); Tue, 25 Aug 2020 05:27:18 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 369F5C061574 for ; Tue, 25 Aug 2020 02:27:18 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id x7so5927619wro.3 for ; Tue, 25 Aug 2020 02:27:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BsNDHmkedWg4LSFZ2MgEXa16GhrMcrPldUbtM6uF3BE=; b=g37SMro+6IZ/ufN0I7NYn6mlBz9WpLFUW50ZCs4RA58iDFan29yhs1UyYpVfKOj3v/ BjvCJ7ZXAsbXySfkCFtUY9tsxTFXB8IUPf2TXflGzFtKMQMUnq2EJ2+jlKvcqDfjirin JfnAVGslI6yYpmz5SxfQ3NSWNIihm7huO1nizwwXi9bCCyOAwp0CSxSoItZMg4A3HmFY KPHaYWc9hzTMKqWOdtAUVfd3twQ+wyiyIOerMhpBgC+qRqY5zrAddXdLwKnI0jhIh9Pu J6cGF46dJFJN0NNIi/5ZhItx6D6wrJyJZOogzjrN7l3q5CD3k+ZhNeav8IQRXm80uYAb nE2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BsNDHmkedWg4LSFZ2MgEXa16GhrMcrPldUbtM6uF3BE=; b=K/Dt0o7OSQHU9RSUJm+74OVzSf65SSUciz2viwlgK5JZzD+bzB4HCZoWKOv3DonnSO 21g8DINGZCZahPq4EZ7N7OH0ZXPdJNKWtQWiPndcXFVFXe6BeVEvUMTpY4iuqJqjIFps UQdFbxZJ46uMsxrCvTX1CTgDeWHwZJ3vuKE+CoCPZhshzAo/Ur+7ECAguxZqPef/mkoi OtQSThg9OtsZ/GmFv/nDtz+qgVjdFDC2cfIpTFWv7uJWMErpJ2++pT9oSWl8pqey88na 6VEiXt6KCGDLLbp48M3pe7A4R5IU6YOd739+uNsd3wjS+DyIMFHeDx6Q7Mp+a/t+vKWc 2WXw== X-Gm-Message-State: AOAM531W7TCzRbAJ7y9OUfIoYuZX+YAnWh5mR13W5B/WcZb+0LuQnwqS SiUeZCrsibl7VwwbadT0CHgy1M4MDfQ= X-Google-Smtp-Source: ABdhPJzv48wu4UcACEZ8E1s0vYhPvnVTjczXm9d105mHyNfSmc3+Sj32YOXiva6pNxV8Gx9MB9AMuQ== X-Received: by 2002:a5d:6a8b:: with SMTP id s11mr9676323wru.222.1598347636900; Tue, 25 Aug 2020 02:27:16 -0700 (PDT) Received: from kheib-workstation ([37.142.0.228]) by smtp.gmail.com with ESMTPSA id n205sm5394880wma.47.2020.08.25.02.27.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2020 02:27:16 -0700 (PDT) Date: Tue, 25 Aug 2020 12:27:13 +0300 From: Kamal Heib To: Bart Van Assche Cc: linux-rdma@vger.kernel.org, Doug Ledford , Jason Gunthorpe , Zhu Yanjun Subject: Re: [PATCH v3 for-rc] RDMA/rxe: Fix panic when calling kmem_cache_create() Message-ID: <20200825092713.GA194958@kheib-workstation> References: <20200824155220.153854-1-kamalheib1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Aug 24, 2020 at 09:41:14AM -0700, Bart Van Assche wrote: > On 8/24/20 8:52 AM, Kamal Heib wrote: > > +bool rxe_is_loaded; > > The name of this variable seems wrong to me. My understanding is that rxe_module_init() is > called whether or not rxe has been built as a module. Consider renaming this variable into > e.g. "rxe_initialized". > OK, I'll change it. > > diff --git a/drivers/infiniband/sw/rxe/rxe_sysfs.c b/drivers/infiniband/sw/rxe/rxe_sysfs.c > > index ccda5f5a3bc0..12c7ca0764d5 100644 > > --- a/drivers/infiniband/sw/rxe/rxe_sysfs.c > > +++ b/drivers/infiniband/sw/rxe/rxe_sysfs.c > > @@ -61,6 +61,11 @@ static int rxe_param_set_add(const char *val, const struct kernel_param *kp) > > struct net_device *ndev; > > struct rxe_dev *exists; > > + if (!rxe_is_loaded) { > > + pr_err("Please make sure to load the rdma_rxe module first\n"); > > + return -EINVAL; > > + } > > + > > len = sanitize_arg(val, intf, sizeof(intf)); > > if (!len) { > > pr_err("add: invalid interface name\n"); > > The above message is misleading. Consider changing it into e.g. the following: > > Please wait until initialization of the rdma_rxe module has finished. > > Additionally, how about returning -EAGAIN instead of -EINVAL? > Yes, this makes more sense, I'll change it. Thanks, Kamal > Thanks, > > Bart. > >