From: Jason Gunthorpe <jgg@nvidia.com>
To: Md Haris Iqbal <haris.iqbal@cloud.ionos.com>
Cc: <danil.kipnis@cloud.ionos.com>, <jinpu.wang@cloud.ionos.com>,
<linux-rdma@vger.kernel.org>, <dledford@redhat.com>,
<leon@kernel.org>, kernel test robot <rong.a.chen@intel.com>
Subject: Re: [PATCH v3] RDMA/rtrs-srv: Incorporate ib_register_client into rtrs server init
Date: Thu, 27 Aug 2020 08:45:26 -0300 [thread overview]
Message-ID: <20200827114526.GA3997016@nvidia.com> (raw)
In-Reply-To: <20200820034152.1660135-1-haris.iqbal@cloud.ionos.com>
On Thu, Aug 20, 2020 at 09:11:52AM +0530, Md Haris Iqbal wrote:
> +static int rtrs_srv_add_one(struct ib_device *device)
> +{
> + struct rtrs_srv_ctx *ctx;
> + int ret;
> +
> + if (ib_ctx.ib_dev_count)
> + goto out;
Add's can run concurrently with remove and with other adds so this
unlocked variable is racing
Jason
next prev parent reply other threads:[~2020-08-27 15:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 3:41 [PATCH v3] RDMA/rtrs-srv: Incorporate ib_register_client into rtrs server init Md Haris Iqbal
2020-08-20 7:26 ` Leon Romanovsky
2020-08-20 8:51 ` Jinpu Wang
2020-08-20 10:43 ` Leon Romanovsky
2020-08-27 11:45 ` Jason Gunthorpe [this message]
2020-08-27 12:01 ` Haris Iqbal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827114526.GA3997016@nvidia.com \
--to=jgg@nvidia.com \
--cc=danil.kipnis@cloud.ionos.com \
--cc=dledford@redhat.com \
--cc=haris.iqbal@cloud.ionos.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rong.a.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox