From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Mark Bloch <markb@mellanox.com>, "Eli Cohen" <eli@mellanox.co.il>,
Jack Morgenstein <jackm@dev.mellanox.co.il>,
<linux-rdma@vger.kernel.org>, Maor Gottlieb <maorg@nvidia.com>,
Roland Dreier <rolandd@cisco.com>,
Yishai Hadas <yishaih@nvidia.com>, Long Li <longli@microsoft.com>
Subject: Re: [PATCH rdma-rc v1] RDMA/mlx4: Read pkey table length instead of hardcoded value
Date: Thu, 27 Aug 2020 09:18:52 -0300 [thread overview]
Message-ID: <20200827121852.GB4014126@nvidia.com> (raw)
In-Reply-To: <20200824110229.1094376-1-leon@kernel.org>
On Mon, Aug 24, 2020 at 02:02:29PM +0300, Leon Romanovsky wrote:
> From: Mark Bloch <markb@mellanox.com>
>
> If the pkey_table is not available (which is the case when RoCE is not
> supported), the cited commit caused a regression where mlx4_devices
> without RoCE are not created.
>
> Fix this by returning a pkey table length of zero in procedure
> eth_link_query_port() if the pkey-table length reported by the device
> is zero.
>
> Cc: <stable@vger.kernel.org>
> Cc: Long Li <longli@microsoft.com>
> Fixes: 1901b91f9982 ("IB/core: Fix potential NULL pointer dereference in pkey cache")
> Fixes: fa417f7b520e ("IB/mlx4: Add support for IBoE")
> Signed-off-by: Mark Bloch <markb@mellanox.com>
> Reviewed-by: Maor Gottlieb <maorg@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Applied to for-rc, thanks
Jason
prev parent reply other threads:[~2020-08-27 14:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 11:02 [PATCH rdma-rc v1] RDMA/mlx4: Read pkey table length instead of hardcoded value Leon Romanovsky
2020-08-27 12:18 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827121852.GB4014126@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=eli@mellanox.co.il \
--cc=jackm@dev.mellanox.co.il \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=maorg@nvidia.com \
--cc=markb@mellanox.com \
--cc=rolandd@cisco.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox