From: Leon Romanovsky <leon@kernel.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Doug Ledford <dledford@redhat.com>, linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-next v1 01/13] RDMA/cma: Delete from restrack DB after successful destroy
Date: Sun, 6 Sep 2020 17:28:29 +0300 [thread overview]
Message-ID: <20200906142829.GI55261@unreal> (raw)
In-Reply-To: <20200903142716.GA1550655@nvidia.com>
On Thu, Sep 03, 2020 at 11:27:16AM -0300, Jason Gunthorpe wrote:
> On Sun, Aug 30, 2020 at 01:14:24PM +0300, Leon Romanovsky wrote:
> > diff --git a/drivers/infiniband/core/restrack.c b/drivers/infiniband/core/restrack.c
> > index 62fbb0ae9cb4..90fc74106620 100644
> > +++ b/drivers/infiniband/core/restrack.c
> > @@ -330,6 +330,9 @@ void rdma_restrack_del(struct rdma_restrack_entry *res)
> > rt = &dev->res[res->type];
> >
> > old = xa_erase(&rt->xa, res->id);
> > + if (!old &&
> > + (res->type == RDMA_RESTRACK_MR || res->type == RDMA_RESTRACK_QP))
> > + return;
> > WARN_ON(old != res);
> > res->valid = false;
>
> What is this for? It doesn't seem to have anything to do with the cm
> change.
Yes, it is a mix between two patches, will fix.
>
> Calling rdma_testrack_del() on a yet to be added ID should early exit
> from !valid right?
QP and MR are not converted yet to ib_core allocation, and they don't
have wait_for_completion() support yet, this is why we need to ball out
early.
>
> Jason
next prev parent reply other threads:[~2020-09-06 14:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-30 10:14 [PATCH rdma-next v1 00/13] Track memory allocation with restrack DB help Leon Romanovsky
2020-08-30 10:14 ` [PATCH rdma-next v1 01/13] RDMA/cma: Delete from restrack DB after successful destroy Leon Romanovsky
2020-09-03 14:27 ` Jason Gunthorpe
2020-09-06 14:28 ` Leon Romanovsky [this message]
2020-08-30 10:14 ` [PATCH rdma-next v1 02/13] RDMA/mlx5: Don't call to restrack recursively Leon Romanovsky
2020-08-30 10:14 ` [PATCH rdma-next v1 03/13] RDMA/restrack: Count references to the verbs objects Leon Romanovsky
2020-08-30 10:14 ` [PATCH rdma-next v1 04/13] RDMA/restrack: Simplify restrack tracking in kernel flows Leon Romanovsky
2020-08-30 10:14 ` [PATCH rdma-next v1 05/13] RDMA/restrack: Improve readability in task name management Leon Romanovsky
2020-08-30 10:14 ` [PATCH rdma-next v1 06/13] RDMA/cma: Be strict with attaching to CMA device Leon Romanovsky
2020-08-30 10:14 ` [PATCH rdma-next v1 07/13] RDMA/core: Allow drivers to disable restrack DB Leon Romanovsky
2020-09-03 14:02 ` Jason Gunthorpe
2020-09-06 14:25 ` Leon Romanovsky
2020-08-30 10:14 ` [PATCH rdma-next v1 08/13] RDMA/counter: Combine allocation and bind logic Leon Romanovsky
2020-08-30 10:14 ` [PATCH rdma-next v1 09/13] RDMA/restrack: Store all special QPs in restrack DB Leon Romanovsky
2020-08-30 10:14 ` [PATCH rdma-next v1 10/13] RDMA/restrack: Make restrack DB mandatory for IB objects Leon Romanovsky
2020-08-30 10:14 ` [PATCH rdma-next v1 11/13] RDMA/restrack: Support all QP types Leon Romanovsky
2020-08-30 10:14 ` [PATCH rdma-next v1 12/13] RDMA/core: Track device memory MRs Leon Romanovsky
2020-08-30 10:14 ` [PATCH rdma-next v1 13/13] RDMA/restrack: Drop valid restrack field as source of ambiguity Leon Romanovsky
2020-09-03 16:21 ` Jason Gunthorpe
2020-09-06 14:24 ` Leon Romanovsky
2020-09-06 14:28 ` Jason Gunthorpe
2020-09-06 15:24 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200906142829.GI55261@unreal \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox