* [PATCH v2] RDMA/rtrs-srv: Set .release function for rtrs srv device during device init
@ 2020-09-07 10:22 Md Haris Iqbal
2020-09-07 10:33 ` Leon Romanovsky
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Md Haris Iqbal @ 2020-09-07 10:22 UTC (permalink / raw)
To: danil.kipnis, jinpu.wang, linux-rdma, dledford, jgg, leon; +Cc: Md Haris Iqbal
The device .release function was not being set during the device
initialization. This was leading to the below warning, in error cases when
put_srv was called before device_add was called.
Warning:
Device '(null)' does not have a release() function, it is broken and must
be fixed. See Documentation/kobject.txt.
So, set the device .release function during device initialization in the
__alloc_srv() function.
Fixes: baa5b28b7a47 ("RDMA/rtrs-srv: Replace device_register with device_initialize and device_add")
Signed-off-by: Md Haris Iqbal <haris.iqbal@cloud.ionos.com>
---
Change in v2:
Use the complete Fixes line
drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c | 8 --------
drivers/infiniband/ulp/rtrs/rtrs-srv.c | 8 ++++++++
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c
index 2f981ae97076..cf6a2be61695 100644
--- a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c
+++ b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c
@@ -152,13 +152,6 @@ static struct attribute_group rtrs_srv_stats_attr_group = {
.attrs = rtrs_srv_stats_attrs,
};
-static void rtrs_srv_dev_release(struct device *dev)
-{
- struct rtrs_srv *srv = container_of(dev, struct rtrs_srv, dev);
-
- kfree(srv);
-}
-
static int rtrs_srv_create_once_sysfs_root_folders(struct rtrs_srv_sess *sess)
{
struct rtrs_srv *srv = sess->srv;
@@ -172,7 +165,6 @@ static int rtrs_srv_create_once_sysfs_root_folders(struct rtrs_srv_sess *sess)
goto unlock;
}
srv->dev.class = rtrs_dev_class;
- srv->dev.release = rtrs_srv_dev_release;
err = dev_set_name(&srv->dev, "%s", sess->s.sessname);
if (err)
goto unlock;
diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv.c b/drivers/infiniband/ulp/rtrs/rtrs-srv.c
index b61a18e57aeb..28f6414dfa3d 100644
--- a/drivers/infiniband/ulp/rtrs/rtrs-srv.c
+++ b/drivers/infiniband/ulp/rtrs/rtrs-srv.c
@@ -1319,6 +1319,13 @@ static int rtrs_srv_get_next_cq_vector(struct rtrs_srv_sess *sess)
return sess->cur_cq_vector;
}
+static void rtrs_srv_dev_release(struct device *dev)
+{
+ struct rtrs_srv *srv = container_of(dev, struct rtrs_srv, dev);
+
+ kfree(srv);
+}
+
static struct rtrs_srv *__alloc_srv(struct rtrs_srv_ctx *ctx,
const uuid_t *paths_uuid)
{
@@ -1337,6 +1344,7 @@ static struct rtrs_srv *__alloc_srv(struct rtrs_srv_ctx *ctx,
srv->queue_depth = sess_queue_depth;
srv->ctx = ctx;
device_initialize(&srv->dev);
+ srv->dev.release = rtrs_srv_dev_release;
srv->chunks = kcalloc(srv->queue_depth, sizeof(*srv->chunks),
GFP_KERNEL);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] RDMA/rtrs-srv: Set .release function for rtrs srv device during device init
2020-09-07 10:22 [PATCH v2] RDMA/rtrs-srv: Set .release function for rtrs srv device during device init Md Haris Iqbal
@ 2020-09-07 10:33 ` Leon Romanovsky
2020-09-07 12:12 ` Jinpu Wang
2020-09-09 16:28 ` Jason Gunthorpe
2 siblings, 0 replies; 4+ messages in thread
From: Leon Romanovsky @ 2020-09-07 10:33 UTC (permalink / raw)
To: Md Haris Iqbal; +Cc: danil.kipnis, jinpu.wang, linux-rdma, dledford, jgg
On Mon, Sep 07, 2020 at 03:52:16PM +0530, Md Haris Iqbal wrote:
> The device .release function was not being set during the device
> initialization. This was leading to the below warning, in error cases when
> put_srv was called before device_add was called.
>
> Warning:
>
> Device '(null)' does not have a release() function, it is broken and must
> be fixed. See Documentation/kobject.txt.
>
> So, set the device .release function during device initialization in the
> __alloc_srv() function.
>
> Fixes: baa5b28b7a47 ("RDMA/rtrs-srv: Replace device_register with device_initialize and device_add")
> Signed-off-by: Md Haris Iqbal <haris.iqbal@cloud.ionos.com>
> ---
> Change in v2:
> Use the complete Fixes line
>
> drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c | 8 --------
> drivers/infiniband/ulp/rtrs/rtrs-srv.c | 8 ++++++++
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] RDMA/rtrs-srv: Set .release function for rtrs srv device during device init
2020-09-07 10:22 [PATCH v2] RDMA/rtrs-srv: Set .release function for rtrs srv device during device init Md Haris Iqbal
2020-09-07 10:33 ` Leon Romanovsky
@ 2020-09-07 12:12 ` Jinpu Wang
2020-09-09 16:28 ` Jason Gunthorpe
2 siblings, 0 replies; 4+ messages in thread
From: Jinpu Wang @ 2020-09-07 12:12 UTC (permalink / raw)
To: Md Haris Iqbal
Cc: Danil Kipnis, linux-rdma, Doug Ledford, Jason Gunthorpe,
Leon Romanovsky
On Mon, Sep 7, 2020 at 12:22 PM Md Haris Iqbal
<haris.iqbal@cloud.ionos.com> wrote:
>
> The device .release function was not being set during the device
> initialization. This was leading to the below warning, in error cases when
> put_srv was called before device_add was called.
>
> Warning:
>
> Device '(null)' does not have a release() function, it is broken and must
> be fixed. See Documentation/kobject.txt.
>
> So, set the device .release function during device initialization in the
> __alloc_srv() function.
>
> Fixes: baa5b28b7a47 ("RDMA/rtrs-srv: Replace device_register with device_initialize and device_add")
> Signed-off-by: Md Haris Iqbal <haris.iqbal@cloud.ionos.com>
Thanks,
Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com>
> ---
> Change in v2:
> Use the complete Fixes line
>
> drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c | 8 --------
> drivers/infiniband/ulp/rtrs/rtrs-srv.c | 8 ++++++++
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c
> index 2f981ae97076..cf6a2be61695 100644
> --- a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c
> +++ b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c
> @@ -152,13 +152,6 @@ static struct attribute_group rtrs_srv_stats_attr_group = {
> .attrs = rtrs_srv_stats_attrs,
> };
>
> -static void rtrs_srv_dev_release(struct device *dev)
> -{
> - struct rtrs_srv *srv = container_of(dev, struct rtrs_srv, dev);
> -
> - kfree(srv);
> -}
> -
> static int rtrs_srv_create_once_sysfs_root_folders(struct rtrs_srv_sess *sess)
> {
> struct rtrs_srv *srv = sess->srv;
> @@ -172,7 +165,6 @@ static int rtrs_srv_create_once_sysfs_root_folders(struct rtrs_srv_sess *sess)
> goto unlock;
> }
> srv->dev.class = rtrs_dev_class;
> - srv->dev.release = rtrs_srv_dev_release;
> err = dev_set_name(&srv->dev, "%s", sess->s.sessname);
> if (err)
> goto unlock;
> diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv.c b/drivers/infiniband/ulp/rtrs/rtrs-srv.c
> index b61a18e57aeb..28f6414dfa3d 100644
> --- a/drivers/infiniband/ulp/rtrs/rtrs-srv.c
> +++ b/drivers/infiniband/ulp/rtrs/rtrs-srv.c
> @@ -1319,6 +1319,13 @@ static int rtrs_srv_get_next_cq_vector(struct rtrs_srv_sess *sess)
> return sess->cur_cq_vector;
> }
>
> +static void rtrs_srv_dev_release(struct device *dev)
> +{
> + struct rtrs_srv *srv = container_of(dev, struct rtrs_srv, dev);
> +
> + kfree(srv);
> +}
> +
> static struct rtrs_srv *__alloc_srv(struct rtrs_srv_ctx *ctx,
> const uuid_t *paths_uuid)
> {
> @@ -1337,6 +1344,7 @@ static struct rtrs_srv *__alloc_srv(struct rtrs_srv_ctx *ctx,
> srv->queue_depth = sess_queue_depth;
> srv->ctx = ctx;
> device_initialize(&srv->dev);
> + srv->dev.release = rtrs_srv_dev_release;
>
> srv->chunks = kcalloc(srv->queue_depth, sizeof(*srv->chunks),
> GFP_KERNEL);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] RDMA/rtrs-srv: Set .release function for rtrs srv device during device init
2020-09-07 10:22 [PATCH v2] RDMA/rtrs-srv: Set .release function for rtrs srv device during device init Md Haris Iqbal
2020-09-07 10:33 ` Leon Romanovsky
2020-09-07 12:12 ` Jinpu Wang
@ 2020-09-09 16:28 ` Jason Gunthorpe
2 siblings, 0 replies; 4+ messages in thread
From: Jason Gunthorpe @ 2020-09-09 16:28 UTC (permalink / raw)
To: Md Haris Iqbal; +Cc: danil.kipnis, jinpu.wang, linux-rdma, dledford, leon
On Mon, Sep 07, 2020 at 03:52:16PM +0530, Md Haris Iqbal wrote:
> The device .release function was not being set during the device
> initialization. This was leading to the below warning, in error cases when
> put_srv was called before device_add was called.
>
> Warning:
>
> Device '(null)' does not have a release() function, it is broken and must
> be fixed. See Documentation/kobject.txt.
>
> So, set the device .release function during device initialization in the
> __alloc_srv() function.
>
> Fixes: baa5b28b7a47 ("RDMA/rtrs-srv: Replace device_register with device_initialize and device_add")
> Signed-off-by: Md Haris Iqbal <haris.iqbal@cloud.ionos.com>
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com>
> ---
> Change in v2:
> Use the complete Fixes line
>
> drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c | 8 --------
> drivers/infiniband/ulp/rtrs/rtrs-srv.c | 8 ++++++++
> 2 files changed, 8 insertions(+), 8 deletions(-)
Applied to for-rc thanks
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-09 16:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-07 10:22 [PATCH v2] RDMA/rtrs-srv: Set .release function for rtrs srv device during device init Md Haris Iqbal
2020-09-07 10:33 ` Leon Romanovsky
2020-09-07 12:12 ` Jinpu Wang
2020-09-09 16:28 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).