From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BB1EC433E2 for ; Mon, 14 Sep 2020 17:52:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B15B9214F1 for ; Mon, 14 Sep 2020 17:52:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600105922; bh=BmuHmhGhGepfE3o2F1iMhe93hNrOJgfv15hcQoThuOM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=LzJlZcF97C30G5UEnhWZcoyO6xAvCW/tNPxPcRQUDDQ5rXdeik2H8epMBGPaxnijE /FSzBNUgUCBX71Y4Ucm3luqiuGQ22vDhp1ykOQCtTcFC88mp0l8ulLyIrpd3i28azA xlTrhl7SuhDO1s+TjwMufzLg1H/bMqnRgVlITs+Q= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725987AbgINRv6 (ORCPT ); Mon, 14 Sep 2020 13:51:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:48832 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726085AbgINL1B (ORCPT ); Mon, 14 Sep 2020 07:27:01 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E226B208DB; Mon, 14 Sep 2020 11:27:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600082821; bh=BmuHmhGhGepfE3o2F1iMhe93hNrOJgfv15hcQoThuOM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R3be7D/z/HZ9xCp1RfWWFiEiL8TNKISEUju4o/pRQGHhWtWNLptsPVkHR3k7A9uuE vq9/XB5c7F8uJS4s+JsYI3Sv5/s1uHzg99TI5PLcAwHiQeVL9QHPqGL5Mr6eaAT25/ Db+dsika7/qy/MxrJls2qH+whSL2eH1ygBuKP74I= From: Leon Romanovsky To: Doug Ledford , Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Subject: [PATCH rdma-next 1/5] RDMA/mlx5: Remove dead check for EAGAIN after alloc_mr_from_cache() Date: Mon, 14 Sep 2020 14:26:49 +0300 Message-Id: <20200914112653.345244-2-leon@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200914112653.345244-1-leon@kernel.org> References: <20200914112653.345244-1-leon@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Jason Gunthorpe alloc_mr_from_cache() no longer returns EAGAIN, this is just dead code now. Fixes: aad719dcf379 ("RDMA/mlx5: Allow MRs to be created in the cache synchronously") Signed-off-by: Jason Gunthorpe Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/mr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c index 4cedcb8c3b31..6e63c0b36872 100644 --- a/drivers/infiniband/hw/mlx5/mr.c +++ b/drivers/infiniband/hw/mlx5/mr.c @@ -1402,10 +1402,8 @@ struct ib_mr *mlx5_ib_reg_user_mr(struct ib_pd *pd, u64 start, u64 length, if (order <= mr_cache_max_order(dev) && use_umr) { mr = alloc_mr_from_cache(pd, umem, virt_addr, length, ncont, page_shift, order, access_flags); - if (PTR_ERR(mr) == -EAGAIN) { - mlx5_ib_dbg(dev, "cache empty for order %d\n", order); + if (IS_ERR(mr)) mr = NULL; - } } else if (!MLX5_CAP_GEN(dev->mdev, umr_extended_translation_offset)) { if (access_flags & IB_ACCESS_ON_DEMAND) { err = -EINVAL; -- 2.26.2