From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C56E9C2BB84 for ; Wed, 16 Sep 2020 18:19:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95E5321655 for ; Wed, 16 Sep 2020 18:19:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600280388; bh=+JmGQ/EiV4TkHPA7FyaKj9RbV4ow4WAIuKsmvYs9RXs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=rsyYSLgzeuUyYe62JjUKpFcJBeP9WBgbY4qtDor0F/2EOjJBh/bk0ifFybAgjKTrf eDN/Jk8Zg8w8akNgjjyswIFwZ5YOjuvj5aWc7ctIOgmz3c6hzLmfDcWlUmYIxl9n4L v0xO92lOfFFv3c0kVd91pDy7ZnGo8dNDQV67bLbU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727866AbgIPSTp (ORCPT ); Wed, 16 Sep 2020 14:19:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:54682 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727443AbgIPST1 (ORCPT ); Wed, 16 Sep 2020 14:19:27 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CCD5521655; Wed, 16 Sep 2020 18:19:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600280355; bh=+JmGQ/EiV4TkHPA7FyaKj9RbV4ow4WAIuKsmvYs9RXs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rR2p/JKwdTx4oLY0mp8zGuzpdfm4OfMy0RgiayX1p7CNPaZ/dGZ5Vrpv+ItxO6sa1 zkIldfvyGgBuawrbvw2r/3Ch6VyvXeEWUjMQVuusJu/8BwbUOv2l7L+NJdukKAwwvp BenmtdQi2Ld8U0rsUg+tlGdm3f0ge2AC6d9mWASE= Date: Wed, 16 Sep 2020 21:19:11 +0300 From: Leon Romanovsky To: Christoph Hellwig Cc: Doug Ledford , Jason Gunthorpe , Yishai Hadas , linux-rdma@vger.kernel.org Subject: Re: [PATCH rdma-next 2/4] IB/core: Enable ODP sync without faulting Message-ID: <20200916181911.GL486552@unreal> References: <20200914113949.346562-1-leon@kernel.org> <20200914113949.346562-3-leon@kernel.org> <20200916164706.GB11582@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200916164706.GB11582@infradead.org> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, Sep 16, 2020 at 05:47:06PM +0100, Christoph Hellwig wrote: > > + if (fault) { > > + /* > > + * Since we asked for hmm_range_fault() to populate pages, > > Totally pointless line over 80 characters. checkpatch.pl was updated to allow 100 symbols. Regarding "pointless", at least for me it wasn't clear why we don't have HMM_PFN_ERROR check in non-fault path so I asked form Yishai to add this comment. > > > + access_mask = (range.hmm_pfns[pfn_index] & HMM_PFN_WRITE) ? > > + (ODP_READ_ALLOWED_BIT | ODP_WRITE_ALLOWED_BIT) : > > + ODP_READ_ALLOWED_BIT; > > + } > > Another weird overly long line, caused by rather osfucated code. This > really should be something like: > > access_mask = ODP_READ_ALLOWED_BIT; > if (range.hmm_pfns[pfn_index] & HMM_PFN_WRITE) > access_mask |= ODP_WRITE_ALLOWED_BIT; Sure >