From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Leon Romanovsky <leonro@nvidia.com>, <linux-rdma@vger.kernel.org>,
Yishai Hadas <yishaih@nvidia.com>
Subject: Re: [PATCH rdma-next v3] RDMA/mlx4: Provide port number for special QPs
Date: Thu, 17 Sep 2020 12:08:13 -0300 [thread overview]
Message-ID: <20200917150813.GN3699@nvidia.com> (raw)
In-Reply-To: <20200914111857.344434-1-leon@kernel.org>
On Mon, Sep 14, 2020 at 02:18:57PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> Special QPs created by mlx4 have same QP port borrowed from
> the context, while they are expected to have different ones.
>
> Fix it by using HW physical port instead.
>
> It fixes the following error during driver init:
> [ 12.074150] mlx4_core 0000:05:00.0: mlx4_ib: initializing demux service for 128 qp1 clients
> [ 12.084036] <mlx4_ib> create_pv_sqp: Couldn't create special QP (-16)
> [ 12.085123] <mlx4_ib> create_pv_resources: Couldn't create QP1 (-16)
> [ 12.088300] mlx4_en: Mellanox ConnectX HCA Ethernet driver v4.0-0
>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> Changelog:
> v3: mlx4 devices create 2 special QPs in SRIOV mode, separate them by
> port number and special bit. The mlx4 is limited to two ports and not
> going to be extended, and the port_num is not forwarded to FW too, so
> it is safe.
> v2: https://lore.kernel.org/linux-rdma/20200907122156.478360-4-leon@kernel.org/#r
> ---
> drivers/infiniband/hw/mlx4/mad.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
I didn't understand why this was in the restrack series, and the
commit doesn't say when the error can be hit
No fixes line?
Jason
next prev parent reply other threads:[~2020-09-17 19:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 11:18 [PATCH rdma-next v3] RDMA/mlx4: Provide port number for special QPs Leon Romanovsky
2020-09-17 15:08 ` Jason Gunthorpe [this message]
2020-09-17 16:10 ` Leon Romanovsky
2020-09-18 8:46 ` Leon Romanovsky
2020-09-18 11:56 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917150813.GN3699@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).