Re: [PATCH rdma-next v3] RDMA/mlx4: Provide port number for special QPs

[Leon Romanovsky <leon@kernel.org>]

On Thu, Sep 17, 2020 at 07:10:34PM +0300, Leon Romanovsky wrote:
> On Thu, Sep 17, 2020 at 12:08:13PM -0300, Jason Gunthorpe wrote:
> > On Mon, Sep 14, 2020 at 02:18:57PM +0300, Leon Romanovsky wrote:
> > > From: Leon Romanovsky <leonro@nvidia.com>
> > >
> > > Special QPs created by mlx4 have same QP port borrowed from
> > > the context, while they are expected to have different ones.
> > >
> > > Fix it by using HW physical port instead.
> > >
> > > It fixes the following error during driver init:
> > > [   12.074150] mlx4_core 0000:05:00.0: mlx4_ib: initializing demux service for 128 qp1 clients
> > > [   12.084036] <mlx4_ib> create_pv_sqp: Couldn't create special QP (-16)
> > > [   12.085123] <mlx4_ib> create_pv_resources: Couldn't create  QP1 (-16)
> > > [   12.088300] mlx4_en: Mellanox ConnectX HCA Ethernet driver v4.0-0
> > >
> > > Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> > > ---
> > >  Changelog:
> > > v3: mlx4 devices create 2 special QPs in SRIOV mode, separate them by
> > > port number and special bit. The mlx4 is limited to two ports and not
> > > going to be extended, and the port_num is not forwarded to FW too, so
> > > it is safe.
> > > v2: https://lore.kernel.org/linux-rdma/20200907122156.478360-4-leon@kernel.org/#r
> > > ---
> > >  drivers/infiniband/hw/mlx4/mad.c | 9 +++++----
> > >  1 file changed, 5 insertions(+), 4 deletions(-)
> >
> > I didn't understand why this was in the restrack series, and the
> > commit doesn't say when the error can be hit
>
> restrack changes revealed it when I added these special QPs to the DB.
> It is not fix in traditional sense, so no Fixes line.

Anyway, please wait with this patch, it makes troubles in some mlx4
SRIOV tests.

Thanks

>
> Thanks
>
> >
> > No fixes line?
> >
> > Jason