From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A490C43464 for ; Fri, 18 Sep 2020 08:46:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 166A0208B8 for ; Fri, 18 Sep 2020 08:46:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600418780; bh=j+UiB8K87m1SXBzwYK/byUDOxokgtrJaq/2ce+rNLL0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=c8gb4dFJTgU19i3AjyIqqrO6+rMAtYwVPjCezFXWmyDteiGkPdtFuyvVQ7B9gkbcv SQNJTMNgljYsJfwYAjM259V4Fk4AqVRf9LfKkVSidjkRR9jIrNA8u9ZGa+bjdd5V1d 7jc3NvMhG1Kq9Fhe2Th9qg6MONjDXhE57yTAluNQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726253AbgIRIqT (ORCPT ); Fri, 18 Sep 2020 04:46:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:59684 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725900AbgIRIqT (ORCPT ); Fri, 18 Sep 2020 04:46:19 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7ABD320870; Fri, 18 Sep 2020 08:46:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600418778; bh=j+UiB8K87m1SXBzwYK/byUDOxokgtrJaq/2ce+rNLL0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GaoLvaTPn6spkoFGMNORIDIKPfhwrNCVPwuOSHumFmmJdM2AAyEWW0aYQF/CmrLCb g7YIpyGW+bzRBO/bhyICdh0hsEAxndUCdbjiHsbAbx8i9ZYkbaDDtFaBCMDtbhj/c8 690vaxY07a/WVkjj6o2EqQBx20zHljeFv0Iz2m3g= Date: Fri, 18 Sep 2020 11:46:13 +0300 From: Leon Romanovsky To: Jason Gunthorpe Cc: Doug Ledford , linux-rdma@vger.kernel.org, Yishai Hadas Subject: Re: [PATCH rdma-next v3] RDMA/mlx4: Provide port number for special QPs Message-ID: <20200918084613.GQ869610@unreal> References: <20200914111857.344434-1-leon@kernel.org> <20200917150813.GN3699@nvidia.com> <20200917161034.GE869610@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200917161034.GE869610@unreal> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Thu, Sep 17, 2020 at 07:10:34PM +0300, Leon Romanovsky wrote: > On Thu, Sep 17, 2020 at 12:08:13PM -0300, Jason Gunthorpe wrote: > > On Mon, Sep 14, 2020 at 02:18:57PM +0300, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > Special QPs created by mlx4 have same QP port borrowed from > > > the context, while they are expected to have different ones. > > > > > > Fix it by using HW physical port instead. > > > > > > It fixes the following error during driver init: > > > [ 12.074150] mlx4_core 0000:05:00.0: mlx4_ib: initializing demux service for 128 qp1 clients > > > [ 12.084036] create_pv_sqp: Couldn't create special QP (-16) > > > [ 12.085123] create_pv_resources: Couldn't create QP1 (-16) > > > [ 12.088300] mlx4_en: Mellanox ConnectX HCA Ethernet driver v4.0-0 > > > > > > Signed-off-by: Leon Romanovsky > > > --- > > > Changelog: > > > v3: mlx4 devices create 2 special QPs in SRIOV mode, separate them by > > > port number and special bit. The mlx4 is limited to two ports and not > > > going to be extended, and the port_num is not forwarded to FW too, so > > > it is safe. > > > v2: https://lore.kernel.org/linux-rdma/20200907122156.478360-4-leon@kernel.org/#r > > > --- > > > drivers/infiniband/hw/mlx4/mad.c | 9 +++++---- > > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > I didn't understand why this was in the restrack series, and the > > commit doesn't say when the error can be hit > > restrack changes revealed it when I added these special QPs to the DB. > It is not fix in traditional sense, so no Fixes line. Anyway, please wait with this patch, it makes troubles in some mlx4 SRIOV tests. Thanks > > Thanks > > > > > No fixes line? > > > > Jason