From: Jason Gunthorpe <jgg@nvidia.com>
To: Weihang Li <liweihang@huawei.com>
Cc: <dledford@redhat.com>, <leon@kernel.org>,
<linux-rdma@vger.kernel.org>, <linuxarm@huawei.com>
Subject: Re: [PATCH v2 for-next 1/9] RDMA/hns: Refactor process about opcode in post_send()
Date: Fri, 18 Sep 2020 10:47:15 -0300 [thread overview]
Message-ID: <20200918134715.GA304004@nvidia.com> (raw)
In-Reply-To: <1599641854-23160-2-git-send-email-liweihang@huawei.com>
On Wed, Sep 09, 2020 at 04:57:26PM +0800, Weihang Li wrote:
>
> + ret = set_ud_opcode(ud_sq_wqe, wr);
> + if (unlikely(ret)) {
> + ibdev_err(ibdev, "unsupported opcode, opcode = %d.\n",
> + wr->opcode);
No random prints like this. If this is kernel only and something
in-kernel is busted then it is just
if (WARN_ON(ret))
Same for every place in this patch
Jason
next prev parent reply other threads:[~2020-09-18 13:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 8:57 [PATCH v2 for-next 0/9] RDMA/hns: Misc Updates Weihang Li
2020-09-09 8:57 ` [PATCH v2 for-next 1/9] RDMA/hns: Refactor process about opcode in post_send() Weihang Li
2020-09-18 13:47 ` Jason Gunthorpe [this message]
2020-09-19 2:35 ` liweihang
2020-09-09 8:57 ` [PATCH v2 for-next 2/9] RDMA/hns: Add type check in get/set hw field Weihang Li
2020-09-18 13:49 ` Jason Gunthorpe
2020-09-19 8:28 ` liweihang
2020-09-09 8:57 ` [PATCH v2 for-next 3/9] RDMA/hns: Add interception for resizing SRQs Weihang Li
2020-09-18 14:06 ` Jason Gunthorpe
2020-09-19 2:44 ` liweihang
2020-09-09 8:57 ` [PATCH v2 for-next 4/9] RDMA/hns: Correct typo of hns_roce_create_cq() Weihang Li
2020-09-18 14:09 ` Jason Gunthorpe
2020-09-19 2:44 ` liweihang
2020-09-09 8:57 ` [PATCH v2 for-next 5/9] RDMA/hns: Add check for the validity of sl configuration Weihang Li
2020-09-18 14:11 ` Jason Gunthorpe
2020-09-19 2:45 ` liweihang
2020-09-09 8:57 ` [PATCH v2 for-next 6/9] RDMA/hns: Solve the overflow of the calc_pg_sz() Weihang Li
2020-09-18 14:10 ` Jason Gunthorpe
2020-09-19 3:04 ` liweihang
2020-09-09 8:57 ` [PATCH v2 for-next 7/9] RDMA/hns: Fix the wrong value of rnr_retry when querying qp Weihang Li
2020-09-09 8:57 ` [PATCH v2 for-next 8/9] RDMA/hns: Fix configuration of ack_req_freq in QPC Weihang Li
2020-09-09 8:57 ` [PATCH v2 for-next 9/9] RDMA/hns: Fix missing sq_sig_type when querying QP Weihang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918134715.GA304004@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liweihang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).