From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4109C43463 for ; Fri, 18 Sep 2020 15:29:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6421E2078B for ; Fri, 18 Sep 2020 15:29:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="GS37Kps2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726311AbgIRP24 (ORCPT ); Fri, 18 Sep 2020 11:28:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726305AbgIRP2y (ORCPT ); Fri, 18 Sep 2020 11:28:54 -0400 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7983DC0613D0 for ; Fri, 18 Sep 2020 08:28:54 -0700 (PDT) Received: by mail-qk1-x744.google.com with SMTP id o16so6464555qkj.10 for ; Fri, 18 Sep 2020 08:28:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=87exJI9IxcsmEwjFodxzp48tvLwR0SvkIumnx6ayv20=; b=GS37Kps2Y7cepRmntyF2JhjXN55pywjVB6NfRKm3IDQZUIbc3SnfOM2dBj10vSzVP9 9MyByCmtgFQozubkaMoNBtDr54DeBh095RjmM8RbXmt5biYJ7EaaPWFP/UJ9b5yRyGh/ c5mfDT8B+oNsdlnSuxpqlgb8Uxiu3i7kpM5Jt5pcu5tMBC0N/wStqQz/tQMRU3KPDF4o SGttK2J6uCx/4SSr9m0eWrGhYQtlkPEdz1vLjlV1G3WStrIXmg/fTjUUOuiixJ7owRZd CSXWxD4+bsduuRrKVYwTGdw/xxz8y0NvcYFLTXWihUYdvmEJ2M7yJ8Yyr8JI5xzSy71C 0fVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=87exJI9IxcsmEwjFodxzp48tvLwR0SvkIumnx6ayv20=; b=oq3lPqZyaCcmtqjB3TH6KMXt4wMDslIom+Z3aCcDIGYYK62jNfrO4VHwxVUI72mc/z Yrp0HGLHdujxOFLzVMzJls1n9DsjIevyAUohH3feeCoGBtl5RKsU+1DHPqo5qCHl+H7C FaGCI2dj9yv2HX3P2tP+BZ47Lkaus6tlMdOpnn3PRELjSw2eCTsPaNCGO3nAmvDNTuOs qeLhilWBnMZgTzwBz2VhYTX/rtrSWaIcgy6Z5kKKtRl+edJ5/gTz2CPJsH2bNmHF5/ro ykMWHXudeT2AZG0/PNI1ChiLCtMbUJP/xscxEu0OeuNdvTr52CvEQ2Uf1lY7Piw40/Bn lqjg== X-Gm-Message-State: AOAM5320/5Ld0YtSRJtlsAbNky2tuFsP2gLXTzI4rqjXjDPMQoLiTKH6 BgdIHPhOrpya/qfu/IkGPFD/DQ== X-Google-Smtp-Source: ABdhPJxtfdYczByA+wq6Dy80t6ZWfoGQ/n9DkJW66Fk8Bud2jQd+D9ALLnqX4eZSIcD/6lD6QRePAw== X-Received: by 2002:a37:7d87:: with SMTP id y129mr34623123qkc.108.1600442933623; Fri, 18 Sep 2020 08:28:53 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id f8sm2272544qtx.81.2020.09.18.08.28.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2020 08:28:52 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kJIJg-001JgL-2m; Fri, 18 Sep 2020 12:28:52 -0300 Date: Fri, 18 Sep 2020 12:28:52 -0300 From: Jason Gunthorpe To: Oded Gabbay Cc: Greg Kroah-Hartman , izur@habana.ai, Gal Pressman , Jakub Kicinski , "Linux-Kernel@Vger. Kernel. Org" , netdev@vger.kernel.org, SW_Drivers , "David S. Miller" , Andrew Lunn , Florian Fainelli , linux-rdma@vger.kernel.org, Olof Johansson Subject: Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver Message-ID: <20200918152852.GW8409@ziepe.ca> References: <20200918125014.GR8409@ziepe.ca> <20200918132645.GS8409@ziepe.ca> <20200918135915.GT8409@ziepe.ca> <20200918141909.GU8409@ziepe.ca> <20200918150735.GV8409@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Fri, Sep 18, 2020 at 06:15:52PM +0300, Oded Gabbay wrote: > I'm sorry, but you won't be able to convince me here that I need to > "enslave" my entire code to RDMA, just because my ASIC "also" has some > RDMA ports. You can't recreate common shared subsystems in a driver just because you don't want to work with the subsystem. I don't care what else the ASIC has. In Linux the netdev part is exposed through netdev, the RDMA part through RDMA, the totally-not-a-GPU part through drivers/misc. It is always been this way. Chelsio didn't get to rebuild the SCSI stack in their driver just because "storage is a small part of their device" Drivers are not allowed to re-implement I2C/SPI/etc without re-using the comon code for that just because "I2C is a small part of their device" Exposing to userspace the creation of RoCE QPs and their related objects are unambiguously a RDMA subsystem task. I don't even know how you think you can argue it is not. It is your company proudly claiming the device has 100G RoCE ports in all the marketing literature, after all. It is too bad the device has a non-standards compliant implementation of RoCE so this will be a bit hard for you. Oh well. Jason