From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: <zyjzyj2000@gmail.com>, <linux-rdma@vger.kernel.org>,
Bob Pearson <rpearson@hpe.com>
Subject: Re: [PATCH for-next v5 07/12] rdma_rxe: Add support for ibv_query_device_ex
Date: Fri, 18 Sep 2020 20:40:07 -0300 [thread overview]
Message-ID: <20200918234007.GG3699@nvidia.com> (raw)
In-Reply-To: <20200918211517.5295-8-rpearson@hpe.com>
On Fri, Sep 18, 2020 at 04:15:12PM -0500, Bob Pearson wrote:
> Add code to initialize new struct members in
> ib_device_attr as place holders.
>
> Signed-off-by: Bob Pearson <rpearson@hpe.com>
> drivers/infiniband/sw/rxe/rxe.c | 101 ++++++++++++++++++--------
> drivers/infiniband/sw/rxe/rxe_verbs.c | 7 +-
> 2 files changed, 75 insertions(+), 33 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe.c b/drivers/infiniband/sw/rxe/rxe.c
> index fab291245366..8d2be78e72ef 100644
> +++ b/drivers/infiniband/sw/rxe/rxe.c
> @@ -38,40 +38,77 @@ void rxe_dealloc(struct ib_device *ib_dev)
> /* initialize rxe device parameters */
> static void rxe_init_device_param(struct rxe_dev *rxe)
> {
> - rxe->max_inline_data = RXE_MAX_INLINE_DATA;
What actually changed here? Isn't dev_attr zero initialized?
> /* initialize port attributes */
> diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c
> index 21582507ed32..a77f2e0ef68f 100644
> +++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
> @@ -1149,7 +1149,8 @@ int rxe_register_device(struct rxe_dev *rxe, const char *ibdev_name)
> dma_coerce_mask_and_coherent(&dev->dev,
> dma_get_required_mask(&dev->dev));
>
> - dev->uverbs_cmd_mask = BIT_ULL(IB_USER_VERBS_CMD_GET_CONTEXT)
> + dev->uverbs_cmd_mask =
> + BIT_ULL(IB_USER_VERBS_CMD_GET_CONTEXT)
> | BIT_ULL(IB_USER_VERBS_CMD_CREATE_COMP_CHANNEL)
> | BIT_ULL(IB_USER_VERBS_CMD_QUERY_DEVICE)
> | BIT_ULL(IB_USER_VERBS_CMD_QUERY_PORT)
> @@ -1184,6 +1185,10 @@ int rxe_register_device(struct rxe_dev *rxe, const char *ibdev_name)
> | BIT_ULL(IB_USER_VERBS_CMD_DEALLOC_MW)
> ;
>
> + dev->uverbs_ex_cmd_mask =
> + BIT_ULL(IB_USER_VERBS_EX_CMD_QUERY_DEVICE)
> + ;
Hurm, I don't even know why we have this bit, did you see a reason?
Jason
next prev parent reply other threads:[~2020-09-18 23:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 21:15 [PATCH for-next v5 00/12] rdma_rxe: API extensions Bob Pearson
2020-09-18 21:15 ` [PATCH for-next v5 01/12] rdma_rxe: Separat MEM into MR and MW objects Bob Pearson
2020-09-18 21:15 ` [PATCH for-next v5 02/12] rdma_rxe: Enable " Bob Pearson
2020-09-18 21:15 ` [PATCH for-next v5 03/12] rdma_rxe: Let pools support both keys and indices Bob Pearson
2020-09-18 21:15 ` [PATCH for-next v5 04/12] rdma_rxe: Add alloc_mw and dealloc_mw verbs Bob Pearson
2020-09-18 21:15 ` [PATCH for-next v5 05/12] rdma_rxe: Add bind_mw and invalidate_mw verbs Bob Pearson
2020-09-18 21:15 ` [PATCH for-next v5 06/12] rdma_rxe: Add memory access through MWs Bob Pearson
2020-09-19 3:52 ` kernel test robot
2020-09-18 21:15 ` [PATCH for-next v5 07/12] rdma_rxe: Add support for ibv_query_device_ex Bob Pearson
2020-09-18 23:40 ` Jason Gunthorpe [this message]
2020-09-18 21:15 ` [PATCH for-next v5 08/12] rdma_rxe: Add support for extended CQ operations Bob Pearson
2020-09-18 21:15 ` [PATCH for-next v5 09/12] rdma_rxe: Add support for extended QP operations Bob Pearson
2020-09-18 23:40 ` Jason Gunthorpe
2020-09-18 21:15 ` [PATCH for-next v5 10/12] rdma_rxe: Fix pool related bugs Bob Pearson
2020-09-18 23:49 ` Jason Gunthorpe
2020-09-18 21:15 ` [PATCH for-next v5 11/12] rdma_rxe: Fix mcast group allocation bug Bob Pearson
2020-09-18 21:15 ` [PATCH for-next v5 12/12] rdma_rxe: Fix bugs in the multicast receive path Bob Pearson
2020-09-18 23:51 ` [PATCH for-next v5 00/12] rdma_rxe: API extensions Jason Gunthorpe
2020-09-19 8:44 ` Zhu Yanjun
2020-09-19 8:46 ` Zhu Yanjun
2020-09-20 21:13 ` Bob Pearson
2020-09-21 14:10 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918234007.GG3699@nvidia.com \
--to=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearson@hpe.com \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).