From: Leon Romanovsky <leon@kernel.org>
To: Weihang Li <liweihang@huawei.com>
Cc: dledford@redhat.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org,
linuxarm@huawei.com
Subject: Re: [PATCH for-next] RDMA/hns: Support owner mode doorbell
Date: Sun, 27 Sep 2020 09:30:04 +0300 [thread overview]
Message-ID: <20200927063004.GG2280698@unreal> (raw)
In-Reply-To: <1601022214-56412-1-git-send-email-liweihang@huawei.com>
On Fri, Sep 25, 2020 at 04:23:34PM +0800, Weihang Li wrote:
> From: Lang Cheng <chenglang@huawei.com>
>
> The doorbell needs to store PI information into QPC, so the RoCEE should
> wait for the results of storing, that is, it needs two bus operations to
> complete a doorbell. When ROCEE is in SDI mode, multiple doorbells may be
> interlocked because the RoCEE can only handle bus operations serially. So a
> flag to mark if HIP09 is working in SDI mode is added. When the SDI flag is
> set, the ROCEE will ignore the PI information of the doorbell, continue to
> fetch wqe and verify its validity by it's owner_bit.
>
> Signed-off-by: Lang Cheng <chenglang@huawei.com>
> Signed-off-by: Weihang Li <liweihang@huawei.com>
> ---
> drivers/infiniband/hw/hns/hns_roce_device.h | 5 ++++-
> drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 28 ++++++++++++++++++++++------
> drivers/infiniband/hw/hns/hns_roce_qp.c | 3 +++
> 3 files changed, 29 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/infiniband/hw/hns/hns_roce_device.h b/drivers/infiniband/hw/hns/hns_roce_device.h
> index a8183ef..517c127 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_device.h
> +++ b/drivers/infiniband/hw/hns/hns_roce_device.h
> @@ -137,9 +137,10 @@ enum {
> SERV_TYPE_UD,
> };
>
> -enum {
> +enum hns_roce_qp_caps {
> HNS_ROCE_QP_CAP_RQ_RECORD_DB = BIT(0),
> HNS_ROCE_QP_CAP_SQ_RECORD_DB = BIT(1),
> + HNS_ROCE_QP_CAP_OWNER_DB = BIT(2),
> };
>
> enum hns_roce_cq_flags {
> @@ -229,6 +230,8 @@ enum {
> HNS_ROCE_CAP_FLAG_FRMR = BIT(8),
> HNS_ROCE_CAP_FLAG_QP_FLOW_CTRL = BIT(9),
> HNS_ROCE_CAP_FLAG_ATOMIC = BIT(10),
> + HNS_ROCE_CAP_FLAG_SDI_MODE = BIT(14),
> + HNS_ROCE_CAP_FLAG_MAX = BIT(28)
This enum is not used.
Thanks
next prev parent reply other threads:[~2020-09-27 6:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 8:23 [PATCH for-next] RDMA/hns: Support owner mode doorbell Weihang Li
2020-09-27 6:30 ` Leon Romanovsky [this message]
2020-09-27 9:33 ` liweihang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200927063004.GG2280698@unreal \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liweihang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox