From: Jason Gunthorpe <jgg@nvidia.com>
To: Gal Pressman <galpress@amazon.com>
Cc: Doug Ledford <dledford@redhat.com>,
"Wei Hu(Xavier)" <huwei87@hisilicon.com>,
Leon Romanovsky <leon@kernel.org>, <linux-rdma@vger.kernel.org>,
Weihang Li <liweihang@huawei.com>, Lijun Ou <oulijun@huawei.com>,
Bob Pearson <rpearsonhpe@gmail.com>,
Yossi Leybovich <sleybo@amazon.com>,
Yishai Hadas <yishaih@nvidia.com>
Subject: Re: [PATCH 02/11] RDMA: Remove uverbs_ex_cmd_mask values that are linked to functions
Date: Mon, 5 Oct 2020 13:20:49 -0300 [thread overview]
Message-ID: <20201005162049.GZ816047@nvidia.com> (raw)
In-Reply-To: <52566b00-efd8-f797-abe8-2bdd11626213@amazon.com>
On Sun, Oct 04, 2020 at 02:04:17PM +0300, Gal Pressman wrote:
> On 04/10/2020 2:20, Jason Gunthorpe wrote:
> > diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c
> > index 418d133a8fb080..2f3f9b87922e92 100644
> > +++ b/drivers/infiniband/core/uverbs_cmd.c
> > @@ -3753,7 +3753,7 @@ const struct uapi_definition uverbs_def_write_intf[] = {
> > IB_USER_VERBS_EX_CMD_MODIFY_CQ,
> > ib_uverbs_ex_modify_cq,
> > UAPI_DEF_WRITE_I(struct ib_uverbs_ex_modify_cq),
> > - UAPI_DEF_METHOD_NEEDS_FN(create_cq))),
> > + UAPI_DEF_METHOD_NEEDS_FN(modify_cq))),
>
> Good catch, but is it related to this patch?
Yes, previously the uverbs_ex_cmd_mask of
IB_USER_VERBS_EX_CMD_MODIFY_CQ prevented this typo from mattering as
no driver set both the bit and a null ops.
This patch has drivers setting null ops with the bit set, so it must
be fixed now.
Jason
next prev parent reply other threads:[~2020-10-05 16:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-03 23:20 [PATCH 00/11] Reduce uverbs_cmd_mask and remove uverbs_ex_cmd_mask Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 01/11] RDMA/cxgb4: Remove MW support Jason Gunthorpe
2020-10-05 5:56 ` Leon Romanovsky
2020-10-05 16:17 ` Jason Gunthorpe
2020-10-09 16:40 ` Potnuri Bharat Teja
2020-10-14 23:27 ` Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 02/11] RDMA: Remove uverbs_ex_cmd_mask values that are linked to functions Jason Gunthorpe
2020-10-04 11:04 ` Gal Pressman
2020-10-05 16:20 ` Jason Gunthorpe [this message]
2020-10-03 23:20 ` [PATCH 03/11] RDMA: Remove elements in uverbs_cmd_mask that all drivers set Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 04/11] RDMA: Move more uverbs_cmd_mask settings to the core Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 05/11] RDMA: Check srq_type during create_srq Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 06/11] RDMA: Check attr_mask during modify_qp Jason Gunthorpe
2020-10-04 11:02 ` Gal Pressman
2020-10-05 16:19 ` Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 07/11] RDMA: Check flags during create_cq Jason Gunthorpe
2020-10-06 18:04 ` Saleem, Shiraz
2020-10-06 18:13 ` Jason Gunthorpe
2020-10-06 18:23 ` Saleem, Shiraz
2020-10-03 23:20 ` [PATCH 08/11] RDMA: Check create_flags during create_qp Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 09/11] RDMA/core Remove uverbs_ex_cmd_mask Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 10/11] RDMA: Remove uverbs cmds from drivers that don't use them Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 11/11] RDMA: Remove AH from uverbs_cmd_mask Jason Gunthorpe
2020-10-06 18:32 ` [PATCH 00/11] Reduce uverbs_cmd_mask and remove uverbs_ex_cmd_mask Saleem, Shiraz
2020-10-26 22:39 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005162049.GZ816047@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=galpress@amazon.com \
--cc=huwei87@hisilicon.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=liweihang@huawei.com \
--cc=oulijun@huawei.com \
--cc=rpearsonhpe@gmail.com \
--cc=sleybo@amazon.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).