From: Leon Romanovsky <leon@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Adit Ranadive <aditr@vmware.com>,
Ariel Elior <aelior@marvell.com>,
Bernard Metzler <bmt@zurich.ibm.com>,
Christian Benvenuti <benve@cisco.com>,
Dennis Dalessandro <dennis.dalessandro@intel.com>,
Devesh Sharma <devesh.sharma@broadcom.com>,
Faisal Latif <faisal.latif@intel.com>,
Gal Pressman <galpress@amazon.com>, Lijun Ou <oulijun@huawei.com>,
linux-rdma@vger.kernel.org,
Michal Kalderon <mkalderon@marvell.com>,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
Naresh Kumar PBS <nareshkumar.pbs@broadcom.com>,
Nelson Escobar <neescoba@cisco.com>,
Parav Pandit <parav@nvidia.com>,
Parvi Kaustubhi <pkaustub@cisco.com>,
Potnuri Bharat Teja <bharat@chelsio.com>,
Selvin Xavier <selvin.xavier@broadcom.com>,
Shiraz Saleem <shiraz.saleem@intel.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
VMware PV-Drivers <pv-drivers@vmware.com>,
Weihang Li <liweihang@huawei.com>,
"Wei Hu(Xavier)" <huwei87@hisilicon.com>,
Yishai Hadas <yishaih@nvidia.com>,
Zhu Yanjun <yanjunz@nvidia.com>
Subject: Re: [PATCH rdma-next v2] RDMA: Explicitly pass in the dma_device to ib_register_device
Date: Tue, 6 Oct 2020 11:13:34 +0300 [thread overview]
Message-ID: <20201006081334.GL1874917@unreal> (raw)
In-Reply-To: <20201006075749.GA23345@infradead.org>
On Tue, Oct 06, 2020 at 08:57:49AM +0100, Christoph Hellwig wrote:
> On Tue, Oct 06, 2020 at 10:53:45AM +0300, Leon Romanovsky wrote:
> > On Tue, Oct 06, 2020 at 08:35:54AM +0100, Christoph Hellwig wrote:
> > > > + WARN_ON(!IS_ENABLED(CONFIG_DMA_VIRT_OPS) && !dma_device);
> > > > + if (!dma_device) {
> > > > /*
> > > > - * The caller did not provide custom DMA operations. Use the
> > > > - * DMA mapping operations of the parent device.
> > > > + * If the caller does not provide a DMA capable device then the
> > > > + * IB device will be used. In this case the caller should fully
> > > > + * setup the ibdev for DMA. This usually means using
> > > > + * dma_virt_ops.
> > > > */
> > > > + device->dev.dma_ops = &dma_virt_ops;
> > > > + dma_device = &device->dev;
> > >
> > > The lack of the if probably means this will fail to link now when
> > > CONFIG_DMA_VIRT_OPS is not set. This also seems to not remove the
> > > dma_virt_ops assignment in the callers.
> >
> > I expect to see this during driver development/testing. It is not worth
> > to make if() case id device won't be operable.
>
> Then you'll need an ifdef or whatever your preferred method is to
> avoid the dma_virt_ops symbol reference for the !CONFIG_DMA_VIRT_OPS
> case.
diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
index 882a7b389dc3..49d095f45216 100644
--- a/drivers/infiniband/core/device.c
+++ b/drivers/infiniband/core/device.c
@@ -1181,7 +1181,7 @@ static void setup_dma_device(struct ib_device *device,
struct device *dma_device)
{
WARN_ON(!IS_ENABLED(CONFIG_DMA_VIRT_OPS) && !dma_device);
- if (!dma_device) {
+ if (IS_ENABLED(CONFIG_DMA_VIRT_OPS) && !dma_device) {
/*
* If the caller does not provide a DMA capable device then the
* IB device will be used. In this case the caller should fully
next prev parent reply other threads:[~2020-10-06 8:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 7:32 [PATCH rdma-next v2] RDMA: Explicitly pass in the dma_device to ib_register_device Leon Romanovsky
2020-10-06 7:35 ` Christoph Hellwig
2020-10-06 7:53 ` Leon Romanovsky
2020-10-06 7:57 ` Christoph Hellwig
2020-10-06 8:13 ` Leon Romanovsky [this message]
2020-10-06 12:05 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006081334.GL1874917@unreal \
--to=leon@kernel.org \
--cc=aditr@vmware.com \
--cc=aelior@marvell.com \
--cc=benve@cisco.com \
--cc=bharat@chelsio.com \
--cc=bmt@zurich.ibm.com \
--cc=dennis.dalessandro@intel.com \
--cc=devesh.sharma@broadcom.com \
--cc=dledford@redhat.com \
--cc=faisal.latif@intel.com \
--cc=galpress@amazon.com \
--cc=hch@infradead.org \
--cc=huwei87@hisilicon.com \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=liweihang@huawei.com \
--cc=mike.marciniszyn@intel.com \
--cc=mkalderon@marvell.com \
--cc=nareshkumar.pbs@broadcom.com \
--cc=neescoba@cisco.com \
--cc=oulijun@huawei.com \
--cc=parav@nvidia.com \
--cc=pkaustub@cisco.com \
--cc=pv-drivers@vmware.com \
--cc=selvin.xavier@broadcom.com \
--cc=shiraz.saleem@intel.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
--cc=yanjunz@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox