From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AAC1C433DF for ; Fri, 9 Oct 2020 16:56:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3DE4C22280 for ; Fri, 9 Oct 2020 16:56:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389899AbgJIQ4t (ORCPT ); Fri, 9 Oct 2020 12:56:49 -0400 Received: from stargate.chelsio.com ([12.32.117.8]:35837 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389334AbgJIQ4t (ORCPT ); Fri, 9 Oct 2020 12:56:49 -0400 X-Greylist: delayed 994 seconds by postgrey-1.27 at vger.kernel.org; Fri, 09 Oct 2020 12:56:49 EDT Received: from localhost ([10.193.186.242]) by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id 099Ge6QS030157; Fri, 9 Oct 2020 09:40:07 -0700 Date: Fri, 9 Oct 2020 22:10:06 +0530 From: Potnuri Bharat Teja To: Jason Gunthorpe Cc: Leon Romanovsky , "linux-rdma@vger.kernel.org" , Bob Pearson Subject: Re: [PATCH 01/11] RDMA/cxgb4: Remove MW support Message-ID: <20201009164004.GA20779@chelsio.com> References: <0-v1-caa70ba3d1ab+1436e-ucmd_mask_jgg@nvidia.com> <1-v1-caa70ba3d1ab+1436e-ucmd_mask_jgg@nvidia.com> <20201005055652.GE9764@unreal> <20201005161726.GX816047@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201005161726.GX816047@nvidia.com> User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Monday, October 10/05/20, 2020 at 21:47:26 +0530, Jason Gunthorpe wrote: > On Mon, Oct 05, 2020 at 08:56:52AM +0300, Leon Romanovsky wrote: > > > > - mhp->rhp = rhp; > > > - mhp->attr.pdid = php->pdid; > > > - mhp->attr.type = FW_RI_STAG_MW; > > > > 75% of "enum fw_ri_stag_type" can be removed too. > > I think that is the code-gen'd HW API for this driver, I don't mind > leaving it. It seems the HW supports MW, just nobody plumbed it > through to rdma-core > Hi Jason, Agreed its dead code as is but Chelsio HW suports MW and we are yet to decide on requirements, we may probably add userspace support for MW in future. Thanks, Bharat