From: Jason Gunthorpe <jgg@ziepe.ca>
To: Potnuri Bharat Teja <bharat@chelsio.com>
Cc: Leon Romanovsky <leon@kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Bob Pearson <rpearsonhpe@gmail.com>
Subject: Re: [PATCH 01/11] RDMA/cxgb4: Remove MW support
Date: Wed, 14 Oct 2020 20:27:22 -0300 [thread overview]
Message-ID: <20201014232722.GC6763@ziepe.ca> (raw)
In-Reply-To: <20201009164004.GA20779@chelsio.com>
On Fri, Oct 09, 2020 at 10:10:06PM +0530, Potnuri Bharat Teja wrote:
> On Monday, October 10/05/20, 2020 at 21:47:26 +0530, Jason Gunthorpe wrote:
> > On Mon, Oct 05, 2020 at 08:56:52AM +0300, Leon Romanovsky wrote:
> >
> > > > - mhp->rhp = rhp;
> > > > - mhp->attr.pdid = php->pdid;
> > > > - mhp->attr.type = FW_RI_STAG_MW;
> > >
> > > 75% of "enum fw_ri_stag_type" can be removed too.
> >
> > I think that is the code-gen'd HW API for this driver, I don't mind
> > leaving it. It seems the HW supports MW, just nobody plumbed it
> > through to rdma-core
> >
> Hi Jason,
> Agreed its dead code as is but Chelsio HW suports MW and we are yet to decide on
> requirements, we may probably add userspace support for MW in future.
You can't add userspace support without modifying the kernel since the
ucmd_mask was never, set. So when/if you get everything working send a
kernel series bringing these functions back.
Jason
next prev parent reply other threads:[~2020-10-15 1:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-03 23:20 [PATCH 00/11] Reduce uverbs_cmd_mask and remove uverbs_ex_cmd_mask Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 01/11] RDMA/cxgb4: Remove MW support Jason Gunthorpe
2020-10-05 5:56 ` Leon Romanovsky
2020-10-05 16:17 ` Jason Gunthorpe
2020-10-09 16:40 ` Potnuri Bharat Teja
2020-10-14 23:27 ` Jason Gunthorpe [this message]
2020-10-03 23:20 ` [PATCH 02/11] RDMA: Remove uverbs_ex_cmd_mask values that are linked to functions Jason Gunthorpe
2020-10-04 11:04 ` Gal Pressman
2020-10-05 16:20 ` Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 03/11] RDMA: Remove elements in uverbs_cmd_mask that all drivers set Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 04/11] RDMA: Move more uverbs_cmd_mask settings to the core Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 05/11] RDMA: Check srq_type during create_srq Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 06/11] RDMA: Check attr_mask during modify_qp Jason Gunthorpe
2020-10-04 11:02 ` Gal Pressman
2020-10-05 16:19 ` Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 07/11] RDMA: Check flags during create_cq Jason Gunthorpe
2020-10-06 18:04 ` Saleem, Shiraz
2020-10-06 18:13 ` Jason Gunthorpe
2020-10-06 18:23 ` Saleem, Shiraz
2020-10-03 23:20 ` [PATCH 08/11] RDMA: Check create_flags during create_qp Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 09/11] RDMA/core Remove uverbs_ex_cmd_mask Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 10/11] RDMA: Remove uverbs cmds from drivers that don't use them Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 11/11] RDMA: Remove AH from uverbs_cmd_mask Jason Gunthorpe
2020-10-06 18:32 ` [PATCH 00/11] Reduce uverbs_cmd_mask and remove uverbs_ex_cmd_mask Saleem, Shiraz
2020-10-26 22:39 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014232722.GC6763@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=bharat@chelsio.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).