Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Adit Ranadive <aditr@vmware.com>
To: jgg@mellanox.com, dledford@redhat.com, linux-rdma@vger.kernel.org
Cc: Adit Ranadive <aditr@vmware.com>, pv-drivers@vmware.com
Subject: [PATCH v1 for-rc] RDMA/vmw_pvrdma: Fix the active_speed and phys_state value
Date: Mon,  2 Nov 2020 22:54:37 +0000	[thread overview]
Message-ID: <20201102225437.26557-1-aditr@vmware.com> (raw)

The PVRDMA device still reports the active_speed in u8.
The pvrdma_port_attr structure is used by the device to report the
port attributes in the device API query port response structure -
pvrdma_cmd_query_port_resp - and shouldn't be changed.

Fixes: 376ceb31ff87 ("RDMA: Fix link active_speed size")
Reviewed-by: Vishnu Dasa <vdasa@vmware.com>
Signed-off-by: Adit Ranadive <aditr@vmware.com>
---

Changelog:
 - v0->v1: Reverted the structure layout only as per Jason. Updated description.
---
 drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.h b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.h
index f0e5ffba2d51..97ed8f952f6e 100644
--- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.h
+++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.h
@@ -176,7 +176,7 @@ struct pvrdma_port_attr {
 	u8			subnet_timeout;
 	u8			init_type_reply;
 	u8			active_width;
-	u16			active_speed;
+	u8			active_speed;
 	u8			phys_state;
 	u8			reserved[2];
 };
-- 
2.18.1


             reply	other threads:[~2020-11-02 22:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-02 22:54 Adit Ranadive [this message]
2020-11-03  0:02 ` [PATCH v1 for-rc] RDMA/vmw_pvrdma: Fix the active_speed and phys_state value Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201102225437.26557-1-aditr@vmware.com \
    --to=aditr@vmware.com \
    --cc=dledford@redhat.com \
    --cc=jgg@mellanox.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=pv-drivers@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox