From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 350C0C00A89 for ; Tue, 3 Nov 2020 00:03:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B2C502225E for ; Tue, 3 Nov 2020 00:03:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="HW8VJaq2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726492AbgKCADB (ORCPT ); Mon, 2 Nov 2020 19:03:01 -0500 Received: from nat-hk.nvidia.com ([203.18.50.4]:41640 "EHLO nat-hk.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725869AbgKCADB (ORCPT ); Mon, 2 Nov 2020 19:03:01 -0500 Received: from HKMAIL102.nvidia.com (Not Verified[10.18.92.77]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 03 Nov 2020 08:02:59 +0800 Received: from HKMAIL103.nvidia.com (10.18.16.12) by HKMAIL102.nvidia.com (10.18.16.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 3 Nov 2020 00:02:59 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 3 Nov 2020 00:02:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IzuSzSrDEi+PpeO6vfqv9veCr+4JoVTysvvFV+gLaojwqHF3vhucXbss0J381zN09WPqNjY+htKhqmxUwu5YblDqGO71GGsZgi2xRYFVdxjDtqTUh6z7YmN6kLp2d4XFI3lF07tnHEmi9kxoTY1CB1CeVn1MDiHWKl3FsU8AKRMecXleE4tVwZgJK1nKCO7ePDVYxfIIsRvR5Wzx/HPnjfjKLgHJXIg48jwQRuBWJTp9fbvz/ZfbrxqqAFduEWf6lu3gOiSpj0kH3yLSI57XiSTb0ZPUgkp9wBCjbixoRtI+lXFfLnqstDjxwaqb4LZAp/w9Qu3427QXypkjgYFhUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tEWTApxt69eLdJiVh4Bas5DprF8ni9T6ufOBEtdjudo=; b=DUi7uwOrHf5mDAfTFm89SmCLH4Y7Eu3ZYdzRoLO6N0+xAZEn3YqLnfuZEJLAMzkHL6WGzFAn1aOyAf8+xDyIsS1z/B6RHVzXV8/IwdO9d4yV7VsN4vJJ4g1u5jiopKYyKVgupJn6rwoJAs3ckdUei+1o41EKI8ESrT2EM7NiRtnQeamvvy7NpHKZx89ocM07gxDA2Rf279Er465g0eq3I1sliExaPTzlpXj2O9Uz2b/BYR47cZ/F3vrntnaCMF5wymM2Ik+FMnMiZ0/NLzcGqWcBQWvSmDX83d+HtJ/rf2Uu9Jf8wm8Ws5HcFqoYf+WZsfsJg8m6PWJxIorbhq2s9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB3834.namprd12.prod.outlook.com (2603:10b6:5:14a::12) by DM6PR12MB3307.namprd12.prod.outlook.com (2603:10b6:5:15d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.27; Tue, 3 Nov 2020 00:02:56 +0000 Received: from DM6PR12MB3834.namprd12.prod.outlook.com ([fe80::cdbe:f274:ad65:9a78]) by DM6PR12MB3834.namprd12.prod.outlook.com ([fe80::cdbe:f274:ad65:9a78%7]) with mapi id 15.20.3499.030; Tue, 3 Nov 2020 00:02:56 +0000 Date: Mon, 2 Nov 2020 20:02:54 -0400 From: Jason Gunthorpe To: Adit Ranadive CC: , , Subject: Re: [PATCH v1 for-rc] RDMA/vmw_pvrdma: Fix the active_speed and phys_state value Message-ID: <20201103000254.GA3741762@nvidia.com> References: <20201102225437.26557-1-aditr@vmware.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20201102225437.26557-1-aditr@vmware.com> X-ClientProxiedBy: MN2PR02CA0034.namprd02.prod.outlook.com (2603:10b6:208:fc::47) To DM6PR12MB3834.namprd12.prod.outlook.com (2603:10b6:5:14a::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mlx.ziepe.ca (156.34.48.30) by MN2PR02CA0034.namprd02.prod.outlook.com (2603:10b6:208:fc::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18 via Frontend Transport; Tue, 3 Nov 2020 00:02:56 +0000 Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kZjmo-00FhQs-5H; Mon, 02 Nov 2020 20:02:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1604361779; bh=tEWTApxt69eLdJiVh4Bas5DprF8ni9T6ufOBEtdjudo=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Date: From:To:CC:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:X-ClientProxiedBy:MIME-Version: X-MS-Exchange-MessageSentRepresentingType; b=HW8VJaq2qy8IafKQ1kAvzYkqZ6U/IuYH/MN/+YC9QbfoNuPRpKDMmdOmND7cs2mLZ h9qvNsd8zebWVMhivpbls5mNRGg5t269BkdJy6RUxm4awkeQ7Zqpwu3x3uIxuuSnUg RLUE4UTrbaOyHPSHoAqUiwKsXjGhpTSQo1I9UgMBiabbCdmJv9hdLRWum82fYT3F/O jnGggcMI3m0lCdMaw6I770tv+muyhxcHqcEkJffj6UUJHZFGfsuqKrsddjxNka9NZr Ze0e/oLV6qP8K6oOHMtz6j5Spb6EoxvsrNZ/Jh2Oqv2vQ0Y5VWOi/J7vzIUHjR94Nh tWgIKrNiWBAcQ== Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Nov 02, 2020 at 10:54:37PM +0000, Adit Ranadive wrote: > The PVRDMA device still reports the active_speed in u8. > The pvrdma_port_attr structure is used by the device to report the > port attributes in the device API query port response structure - > pvrdma_cmd_query_port_resp - and shouldn't be changed. > > Fixes: 376ceb31ff87 ("RDMA: Fix link active_speed size") > Reviewed-by: Vishnu Dasa > Signed-off-by: Adit Ranadive > --- > > Changelog: > - v0->v1: Reverted the structure layout only as per Jason. Updated description. > --- > drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to for-rc If you think it is better you can send another patch to use the ib_get_eth_speed() function Also please send a patch to move all of these ABI structs into the pvrdma_dev_api.h - ABI structures should not be strewn randomly over header files, it leads to mistakes like this. Thanks, Jason