Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>,
	Edward Srouji <edwards@mellanox.com>
Cc: Leon Romanovsky <leon@kernel.org>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: pyverbs test regression
Date: Tue, 3 Nov 2020 20:00:20 -0400	[thread overview]
Message-ID: <20201104000020.GU2620339@nvidia.com> (raw)
In-Reply-To: <f8de77b3-d9c7-5b0f-c118-c95f0c6a271c@gmail.com>

On Tue, Nov 03, 2020 at 05:54:58PM -0600, Bob Pearson wrote:
> Since 5.10 some of the pyverbs tests are skipping with the warning
> 	"Device rxe_0 doesn't have net interface"
> 
> These occur in tests/test_rdmacm.py. As far as I can tell the error occurs in
> 
> RDMATestCase _add_gids_per_port after the following
> 
> 	    if not os.path.exists('/sys/class/infiniband/{}/device/net/'.format(dev)):
>                 self.args.append([dev, port, idx, None])
>                 continue
> 
> In fact there is no such path which means it never finds an ip_addr for the device.

That isn't an acceptable way to find netdevs for a RDMA device..

This test is really buggy, that is not an acceptable way to find the
netdev for a RDMA device. Looks like it is some hacky way to read the
gid table? It should just read the gid table.. Edward?

> Did something change here? Do other RDMA devices have /sys/class/infiniband/XXX/device/net?

Yes, some will

Jason

  reply	other threads:[~2020-11-04  0:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-03 23:54 pyverbs test regression Bob Pearson
2020-11-04  0:00 ` Jason Gunthorpe [this message]
2020-11-04 10:40   ` Edward Srouji
2020-11-04 11:47     ` Gal Pressman
2020-11-04 17:46       ` Bob Pearson
2020-11-04 12:36     ` Jason Gunthorpe
2020-11-04 18:34       ` Edward Srouji
2020-11-04 18:43         ` Jason Gunthorpe
2020-11-04 13:53 ` Bernard Metzler
2020-11-04 17:06   ` Bob Pearson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201104000020.GU2620339@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=edwards@mellanox.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=rpearsonhpe@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox