From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2467C2D0A3 for ; Wed, 4 Nov 2020 14:40:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BFB220756 for ; Wed, 4 Nov 2020 14:40:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604500831; bh=JDZqeEdi14yeP8RqmvGxLRLBiAhK+IVpQMxy7xeG+MQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=uOtT/kLHu3SyOdYWV/5lmUaIkaVJ6KGZKmt2utZUI05wabVE4etYaurXggVVHHixY DKViO4tqynytbjwTDBwlc1yKEkxIxLjrq+EOV7TxlBXnyVUkv+wK2OtC+fLdk06N8N c75wyFRWT1D4Ji3xqQFtb3Fju51xYul9LLe9RtPU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729630AbgKDOka (ORCPT ); Wed, 4 Nov 2020 09:40:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:44500 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726564AbgKDOka (ORCPT ); Wed, 4 Nov 2020 09:40:30 -0500 Received: from localhost (searspoint.nvidia.com [216.228.112.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 637842074B; Wed, 4 Nov 2020 14:40:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604500829; bh=JDZqeEdi14yeP8RqmvGxLRLBiAhK+IVpQMxy7xeG+MQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aYGNhUn0E9puCrm9MRlbENPt+07bK8DCEcI6CJfXsbZQg0+aNEg8h3F7P+n6ET695 9mIlhOB9pAtcvwpIG4jpnFT8L6Cw6jN/0USLtJFLsUStZ6guN/h3hz52db77n5PHkL l2ykL1CEFiXrsVqAizHE/lINCmEnozB5WJ3cQTX4= From: Leon Romanovsky To: Doug Ledford , Jason Gunthorpe Cc: Leon Romanovsky , linux-rdma@vger.kernel.org Subject: [PATCH rdma-next v4 5/5] RDMA/cma: Be strict with attaching to CMA device Date: Wed, 4 Nov 2020 16:40:08 +0200 Message-Id: <20201104144008.3808124-6-leon@kernel.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201104144008.3808124-1-leon@kernel.org> References: <20201104144008.3808124-1-leon@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Leon Romanovsky The RDMA-CM code wasn't consistent in flows that attached to cma_dev, this caused to situations where a failure during attach to listen on such device leaves RDMA-CM in a non-consistent state. Change the _cma_attach_to_dev to return an error in case of failure, so listen/attach flows will deal correctly with the failures. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/cma.c | 42 +++++++++++++++++++++++------------ 1 file changed, 28 insertions(+), 14 deletions(-) diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c index 89cc4b0a48ec..290624150c20 100644 --- a/drivers/infiniband/core/cma.c +++ b/drivers/infiniband/core/cma.c @@ -448,8 +448,8 @@ static int cma_igmp_send(struct net_device *ndev, union ib_gid *mgid, bool join) return (in_dev) ? 0 : -ENODEV; } -static void _cma_attach_to_dev(struct rdma_id_private *id_priv, - struct cma_device *cma_dev) +static int _cma_attach_to_dev(struct rdma_id_private *id_priv, + struct cma_device *cma_dev) { cma_dev_get(cma_dev); id_priv->cma_dev = cma_dev; @@ -460,15 +460,22 @@ static void _cma_attach_to_dev(struct rdma_id_private *id_priv, rdma_restrack_add(&id_priv->res); trace_cm_id_attach(id_priv, cma_dev->device); + return 0; } -static void cma_attach_to_dev(struct rdma_id_private *id_priv, - struct cma_device *cma_dev) +static int cma_attach_to_dev(struct rdma_id_private *id_priv, + struct cma_device *cma_dev) { - _cma_attach_to_dev(id_priv, cma_dev); + int ret; + + ret = _cma_attach_to_dev(id_priv, cma_dev); + if (ret) + return ret; + id_priv->gid_type = cma_dev->default_gid_type[id_priv->id.port_num - rdma_start_port(cma_dev->device)]; + return 0; } static void cma_release_dev(struct rdma_id_private *id_priv) @@ -633,8 +640,7 @@ static int cma_acquire_dev_by_src_ip(struct rdma_id_private *id_priv) if (!IS_ERR(sgid_attr)) { id_priv->id.port_num = port; cma_bind_sgid_attr(id_priv, sgid_attr); - cma_attach_to_dev(id_priv, cma_dev); - ret = 0; + ret = cma_attach_to_dev(id_priv, cma_dev); goto out; } } @@ -663,6 +669,7 @@ static int cma_ib_acquire_dev(struct rdma_id_private *id_priv, const struct ib_gid_attr *sgid_attr; enum ib_gid_type gid_type; union ib_gid gid; + int ret; if (dev_addr->dev_type != ARPHRD_INFINIBAND && id_priv->id.ps == RDMA_PS_IPOIB) @@ -688,9 +695,9 @@ static int cma_ib_acquire_dev(struct rdma_id_private *id_priv, * cma_process_remove(). */ mutex_lock(&lock); - cma_attach_to_dev(id_priv, listen_id_priv->cma_dev); + ret = cma_attach_to_dev(id_priv, listen_id_priv->cma_dev); mutex_unlock(&lock); - return 0; + return ret; } static int cma_iw_acquire_dev(struct rdma_id_private *id_priv, @@ -745,7 +752,7 @@ static int cma_iw_acquire_dev(struct rdma_id_private *id_priv, out: if (!ret) - cma_attach_to_dev(id_priv, cma_dev); + ret = cma_attach_to_dev(id_priv, cma_dev); mutex_unlock(&lock); return ret; @@ -762,7 +769,7 @@ static int cma_resolve_ib_dev(struct rdma_id_private *id_priv) unsigned int p; u16 pkey, index; enum ib_port_state port_state; - int i; + int i, ret; cma_dev = NULL; addr = (struct sockaddr_ib *) cma_dst_addr(id_priv); @@ -805,8 +812,10 @@ static int cma_resolve_ib_dev(struct rdma_id_private *id_priv) return -ENODEV; found: - cma_attach_to_dev(id_priv, cma_dev); + ret = cma_attach_to_dev(id_priv, cma_dev); mutex_unlock(&lock); + if (ret) + return ret; addr = (struct sockaddr_ib *)cma_src_addr(id_priv); memcpy(&addr->sib_addr, &sgid, sizeof(sgid)); cma_translate_ib(addr, &id_priv->id.route.addr.dev_addr); @@ -2517,7 +2526,9 @@ static int cma_listen_on_dev(struct rdma_id_private *id_priv, memcpy(cma_src_addr(dev_id_priv), cma_src_addr(id_priv), rdma_addr_size(cma_src_addr(id_priv))); - _cma_attach_to_dev(dev_id_priv, cma_dev); + ret = _cma_attach_to_dev(dev_id_priv, cma_dev); + if (ret) + goto err_attach; list_add_tail(&dev_id_priv->listen_list, &id_priv->listen_list); cma_id_get(id_priv); dev_id_priv->internal_id = 1; @@ -2531,6 +2542,7 @@ static int cma_listen_on_dev(struct rdma_id_private *id_priv, return 0; err_listen: list_del(&id_priv->listen_list); +err_attach: dev_warn(&cma_dev->device->dev, "RDMA CMA: %s, error %d\n", __func__, ret); rdma_destroy_id(&dev_id_priv->id); return ret; @@ -3128,7 +3140,9 @@ static int cma_bind_loopback(struct rdma_id_private *id_priv) rdma_addr_set_sgid(&id_priv->id.route.addr.dev_addr, &gid); ib_addr_set_pkey(&id_priv->id.route.addr.dev_addr, pkey); id_priv->id.port_num = p; - cma_attach_to_dev(id_priv, cma_dev); + ret = cma_attach_to_dev(id_priv, cma_dev); + if (ret) + goto out; cma_set_loopback(cma_src_addr(id_priv)); out: mutex_unlock(&lock); -- 2.28.0