From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2201FC388F7 for ; Tue, 10 Nov 2020 13:41:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C29B620731 for ; Tue, 10 Nov 2020 13:41:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="OCcwk+Ef" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730897AbgKJNlZ (ORCPT ); Tue, 10 Nov 2020 08:41:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730373AbgKJNlZ (ORCPT ); Tue, 10 Nov 2020 08:41:25 -0500 Received: from mail-qv1-xf41.google.com (mail-qv1-xf41.google.com [IPv6:2607:f8b0:4864:20::f41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 408A0C0613CF for ; Tue, 10 Nov 2020 05:41:25 -0800 (PST) Received: by mail-qv1-xf41.google.com with SMTP id q7so2025929qvt.12 for ; Tue, 10 Nov 2020 05:41:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SMCHyYQ6JN9Tw0XiHQc2rDlJH0TI4VqmvKvthC2CIQo=; b=OCcwk+EfYsFc0zbPWbQlZCdovJ5r7vn1vHdvzvoL/UWKmlYslSF9eAmLtPTmnAUBQO Qf2usvs7bXO0BJvObaGGcjlH9a7PJzvQCxHzY7/E4AVAw9HV8yNBFM1UmPAFJakZH0FM TH6CV5NYH9Gt80G7DsbbpwROkL+hBYsxNPVT8bfiRw765UligGYKBNZCHBPptQssAnBR KJpx6mxFIMFtclsMYzJe+M3fq+2g8mOGuX+blJzKFfTdz8qvubfR9EsMIkXG4woDyIvn tw/m1xTI0lAET+5mrrpl78782S69qP0knd/pQDtyzERkFK5pLhhBIP6vdbJl/L6x6WdP 92MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SMCHyYQ6JN9Tw0XiHQc2rDlJH0TI4VqmvKvthC2CIQo=; b=hcOq3b59fxhH2PwKepATN3vb+mEJJdo1XGVMfiPZqr6N/BQp6T5s4S24gXfxW7OI61 ooy25zWuy/8HXo5wYVjIMYlLJF8Gt4e1tRxCSeiVcJIyaQ0kvWZ/8SEtzbwHoz/8COG+ bv8YvWado8Wg0vsehX+45Lnbf6SLjsBx4yXbK6I7rUWQu1UQbFaLWAXGUmYW2QZVrVKx 3uvMJXre4s9kmiTywk7ECAhFn7bBL9Ha+ks5SN39t4AV75+a2myhBl+o5LVUlmPtitfC pwVdWjFrT3GB+BF3vuPybLGtHKYqjQ056yMudR7o0js2qeV9wBYbHKx/zh+vpG93Fbnt z2Vw== X-Gm-Message-State: AOAM533xnrKVg5VoypXEqpn3LoR2zOaF37cbuw23aj3JCsHYOiwMa/z2 ty7m4nxl8ZMnBy+cnT344KuGfg== X-Google-Smtp-Source: ABdhPJyaqyWhKjcmKRSgzo9QlgovWPTAP/Cc1vROwqTLo9mTPpzC7s+L4Vb9sR+VQ2BfGpFgHxDOwA== X-Received: by 2002:a0c:a5a2:: with SMTP id z31mr20236933qvz.15.1605015684496; Tue, 10 Nov 2020 05:41:24 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id e18sm8018950qtc.39.2020.11.10.05.41.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 05:41:23 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kcTti-002Q93-Uy; Tue, 10 Nov 2020 09:41:22 -0400 Date: Tue, 10 Nov 2020 09:41:22 -0400 From: Jason Gunthorpe To: Gal Pressman Cc: Leon Romanovsky , Doug Ledford , linux-rdma@vger.kernel.org Subject: Re: [PATCH for-next] RDMA/nldev: Add parent bdf to device information dump Message-ID: <20201110134122.GL244516@ziepe.ca> References: <20201103135719.GK5429@unreal> <0825e1bf-f913-d2c1-ad3f-35ba3d6b75ef@amazon.com> <20201103142243.GM36674@ziepe.ca> <5e2208ab-9e87-56ae-bc38-5827637eb5be@amazon.com> <20201105200005.GJ36674@ziepe.ca> <20201108234935.GC244516@ziepe.ca> <7a9866b6-fa33-0b95-4bda-4c83112be369@amazon.com> <20201109175700.GF244516@ziepe.ca> <6c77ad03-db3b-a1f8-cd28-a744585ba26d@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6c77ad03-db3b-a1f8-cd28-a744585ba26d@amazon.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, Nov 10, 2020 at 09:49:11AM +0200, Gal Pressman wrote: > On 09/11/2020 19:57, Jason Gunthorpe wrote: > > On Mon, Nov 09, 2020 at 11:03:47AM +0200, Gal Pressman wrote: > > > >>> The thing is, is is still useless. You have to consult sysfs to > >>> understand what bus it is scoped on to do anything further with > >>> it. Can't just assume it is PCI. > >> > >> This can be solved with Parav's suggestion. > > > > Now you are adding more stuff. > > > > What is wrong with reading sysfs? sysfs is where topology information > > lives, why do we need to denormalize things? > > And yet you have lspci so you don't have to dig through the sysfs files by hand > for that topology. > Please drop this patch. If you want to add something to rdma tool it can read sysfs and disply it Jason