public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Gal Pressman <galpress@amazon.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
	Doug Ledford <dledford@redhat.com>,
	linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-next 1/2] RDMA/core: Check .create_ah is not NULL only in case it's needed
Date: Sun, 15 Nov 2020 13:15:43 +0200	[thread overview]
Message-ID: <20201115111543.GC47002@unreal> (raw)
In-Reply-To: <20201115103404.48829-2-galpress@amazon.com>

On Sun, Nov 15, 2020 at 12:34:02PM +0200, Gal Pressman wrote:
> Drivers now expose two callbacks for address handle creation, one for
> uverbs and one for kverbs. The function pointer NULL check in
> _rdma_create_ah() should only happen if !udata.
>
> A NULL check for .create_user_ah is not needed as it is validated by the
> uverbs uapi definitions.
>
> Fixes: 676a80adba01 ("RDMA: Remove AH from uverbs_cmd_mask")
> Signed-off-by: Gal Pressman <galpress@amazon.com>
> ---
>  drivers/infiniband/core/verbs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>

  reply	other threads:[~2020-11-15 11:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-15 10:34 [PATCH for-next 0/2] create_user_ah introduction fixups Gal Pressman
2020-11-15 10:34 ` [PATCH for-next 1/2] RDMA/core: Check .create_ah is not NULL only in case it's needed Gal Pressman
2020-11-15 11:15   ` Leon Romanovsky [this message]
2020-11-16 18:22   ` Jason Gunthorpe
2020-11-16 18:32     ` Gal Pressman
2020-11-15 10:34 ` [PATCH for-next 2/2] RDMA/efa: Remove .create_ah callback assignment Gal Pressman
2020-11-15 11:15   ` Leon Romanovsky
2020-11-16 20:52 ` [PATCH for-next 0/2] create_user_ah introduction fixups Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201115111543.GC47002@unreal \
    --to=leon@kernel.org \
    --cc=dledford@redhat.com \
    --cc=galpress@amazon.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox