From: Jason Gunthorpe <jgg@nvidia.com>
To: "Saleem, Shiraz" <shiraz.saleem@intel.com>
Cc: zhudi <zhudi21@huawei.com>,
"Latif, Faisal" <faisal.latif@intel.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"rose.chen@huawei.com" <rose.chen@huawei.com>
Subject: Re: [PATCH] RDMA/i40iw: Fix a mmap handler exploitation
Date: Fri, 20 Nov 2020 20:18:02 -0400 [thread overview]
Message-ID: <20201121001802.GL917484@nvidia.com> (raw)
In-Reply-To: <9edd382c89c64c988b8833f22fe027ba@intel.com>
On Fri, Nov 20, 2020 at 11:56:36PM +0000, Saleem, Shiraz wrote:
> Well, the push feature is disabled by default and today there will
> be no push page mmap from user-space since uresp.push_idx is an
> invalid one. Its disabled for good reason as its not working as
> expected. There is an option to turn it on via module param but that
> does not work as expected still resulting in an invalid
> uresp.push_idx passed to user-space and no mmap.
>
> So isn’t it better to just remove the push related code in the
> driver? which should also remove the manipulation on the vm_pgoff I
> believe.
Yes, delete all the push code, module param, etc. Set the invalid
push_idx, verify vm_pgoff == 0 and hardwire the pfn to be a single BAR
page.
Can you send a patch soon?
> I will review the mmap API and see how we can use it for DB mmap.
This would be something to use if you ever make it work again
Jason
next prev parent reply other threads:[~2020-11-21 0:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 9:35 [PATCH] RDMA/i40iw: Fix a mmap handler exploitation zhudi
2020-11-19 17:27 ` Jason Gunthorpe
2020-11-20 23:56 ` Saleem, Shiraz
2020-11-21 0:18 ` Jason Gunthorpe [this message]
2020-11-21 2:45 ` Saleem, Shiraz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201121001802.GL917484@nvidia.com \
--to=jgg@nvidia.com \
--cc=faisal.latif@intel.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rose.chen@huawei.com \
--cc=shiraz.saleem@intel.com \
--cc=zhudi21@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox