From: Jason Gunthorpe <jgg@nvidia.com>
To: Bernard Metzler <bmt@zurich.ibm.com>,
Doug Ledford <dledford@redhat.com>, <linux-rdma@vger.kernel.org>,
Zhu Yanjun <yanjunz@nvidia.com>,
"Pearson, Robert B" <robert.pearson2@hpe.com>
Subject: Re: [PATCH] RDMA/siw,rxe: Make emulated devices virtual in the device tree
Date: Mon, 23 Nov 2020 16:15:48 -0400 [thread overview]
Message-ID: <20201123201548.GA43190@nvidia.com> (raw)
In-Reply-To: <0-v1-dcbfc68c4b4a+d6-virtual_dev_jgg@nvidia.com>
On Fri, Nov 06, 2020 at 10:00:49AM -0400, Jason Gunthorpe wrote:
> This moves siw and rxe to be virtual devices in the device tree:
>
> lrwxrwxrwx 1 root root 0 Nov 6 13:55 /sys/class/infiniband/rxe0 -> ../../devices/virtual/infiniband/rxe0/
>
> Previously they were trying to parent themselves to the physical device of
> their attached netdev, which doesn't make alot of sense.
>
> My hope is this will solve some weird syzkaller hits related to sysfs as
> it could be possible that the parent of a netdev is another netdev, eg
> under bonding or some other syzkaller found netdev configuration.
>
> Nesting a ib_device under anything but a physical device is going to cause
> inconsistencies in sysfs during destructions.
>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
> drivers/infiniband/sw/rxe/rxe_net.c | 12 ------------
> drivers/infiniband/sw/rxe/rxe_verbs.c | 1 -
> drivers/infiniband/sw/siw/siw_main.c | 19 +------------------
> 3 files changed, 1 insertion(+), 31 deletions(-)
Applied to for-next
Jason
prev parent reply other threads:[~2020-11-23 20:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 14:00 [PATCH] RDMA/siw,rxe: Make emulated devices virtual in the device tree Jason Gunthorpe
2020-11-07 1:04 ` Bart Van Assche
2020-11-09 20:54 ` Jason Gunthorpe
2020-11-23 20:15 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123201548.GA43190@nvidia.com \
--to=jgg@nvidia.com \
--cc=bmt@zurich.ibm.com \
--cc=dledford@redhat.com \
--cc=linux-rdma@vger.kernel.org \
--cc=robert.pearson2@hpe.com \
--cc=yanjunz@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox