From: Jason Gunthorpe <jgg@ziepe.ca>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: leon@kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [bug report] RDMA/restrack: Store all special QPs in restrack DB
Date: Thu, 26 Nov 2020 13:30:36 -0400 [thread overview]
Message-ID: <20201126173036.GT5487@ziepe.ca> (raw)
In-Reply-To: <20201126113347.GA128957@mwanda>
On Thu, Nov 26, 2020 at 02:33:47PM +0300, Dan Carpenter wrote:
> 231 if (res->type == RDMA_RESTRACK_QP) {
> 232 /* Special case to ensure that LQPN points to right QP */
> 233 struct ib_qp *qp = container_of(res, struct ib_qp, res);
> 234
> 235 WARN_ONCE(qp->qp_num >> 24 || qp->port >> 8,
> ^^^^^^^^^^^^^
> qp->port is a u8 so this is always going to be zero.
I think we should ignore this one. I'm expecting the width of port to
increase..
Jason
prev parent reply other threads:[~2020-11-26 17:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 11:33 [bug report] RDMA/restrack: Store all special QPs in restrack DB Dan Carpenter
2020-11-26 17:30 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126173036.GT5487@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dan.carpenter@oracle.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox