[PATCH] RDMA/bnxt_re: Fix max_qp_wrs reported

[PATCH] RDMA/bnxt_re: Fix max_qp_wrs reported

[Selvin Xavier]

[-- Attachment #1: Type: text/plain, Size: 1211 bytes --]

While creating qps, driver adds one extra entry to the sq size
passed by the ULPs in order to avoid queue full condition.
When ULPs creates QPs with max_qp_wr reported, driver creates
QP with 1 more than the max_wqes supported by HW. Create QP fails
in this case. To avoid this error, reduce 1 entry in max_qp_wqes
and report it to the stack.

Signed-off-by: Devesh Sharma <devesh.sharma@broadcom.com>
Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
---
 drivers/infiniband/hw/bnxt_re/qplib_sp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/bnxt_re/qplib_sp.c b/drivers/infiniband/hw/bnxt_re/qplib_sp.c
index e865690..6c6a9d2 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_sp.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_sp.c
@@ -118,7 +118,7 @@ int bnxt_qplib_get_dev_attr(struct bnxt_qplib_rcfw *rcfw,
 	 * 128 WQEs needs to be reserved for the HW (8916). Prevent
 	 * reporting the max number
 	 */
-	attr->max_qp_wqes -= BNXT_QPLIB_RESERVED_QP_WRS;
+	attr->max_qp_wqes -= (BNXT_QPLIB_RESERVED_QP_WRS + 1);
 	attr->max_qp_sges = bnxt_qplib_is_chip_gen_p5(rcfw->res->cctx) ?
 			    6 : sb->max_sge;
 	attr->max_cq = le32_to_cpu(sb->max_cq);
-- 
2.5.5


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4181 bytes --]

Re: [PATCH] RDMA/bnxt_re: Fix max_qp_wrs reported

[Jason Gunthorpe]

On Mon, Nov 30, 2020 at 05:13:06AM -0800, Selvin Xavier wrote:
> While creating qps, driver adds one extra entry to the sq size
> passed by the ULPs in order to avoid queue full condition.
> When ULPs creates QPs with max_qp_wr reported, driver creates
> QP with 1 more than the max_wqes supported by HW. Create QP fails
> in this case. To avoid this error, reduce 1 entry in max_qp_wqes
> and report it to the stack.
> 
> Signed-off-by: Devesh Sharma <devesh.sharma@broadcom.com>
> Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
> ---
>  drivers/infiniband/hw/bnxt_re/qplib_sp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-next, thanks

Jason